luminous: osd: PrimaryLogPG: fix potential pg-log overtrimming#24308
Merged
yuriw merged 1 commit intoceph:luminousfrom Oct 1, 2018
Merged
luminous: osd: PrimaryLogPG: fix potential pg-log overtrimming#24308yuriw merged 1 commit intoceph:luminousfrom
yuriw merged 1 commit intoceph:luminousfrom
Conversation
In ceph#21580 I set a trap to catch some wired and random segmentfaults and in a recent QA run I was able to observe it was successfully triggered by one of the test case, see: ``` http://qa-proxy.ceph.com/teuthology/xxg-2018-07-30_05:25:06-rados-wip-hb-peers-distro-basic-smithi/2837916/teuthology.log ``` The root cause is that there might be holes on log versions, thus the approx_size() method should (almost) always overestimate the actual number of log entries. As a result, we might be at the risk of overtrimming log entries. ceph#18338 reveals a probably easier way to fix the above problem but unfortunately it also can cause big performance regression and hence comes this pr.. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 3654d56) Conflicts: src/osd/PrimaryLogPG.cc: trivial resolution
xiexingguo
approved these changes
Sep 28, 2018
tchaikov
approved these changes
Sep 28, 2018
Contributor
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 5, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 5, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 5, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
3 tasks
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 6, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 6, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 6, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
yuriw
added a commit
to yuriw/ceph
that referenced
this pull request
Nov 6, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
3 tasks
neha-ojha
pushed a commit
to neha-ojha/ceph
that referenced
this pull request
Dec 21, 2018
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com> (cherry picked from commit 867940e)
neha-ojha
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Dec 21, 2018
Fixes: ceph/ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com> (cherry picked from commit 867940e08bd829bbe16cb23ae4337b56e00ff9a6)
neha-ojha
pushed a commit
to ceph/ceph-ci
that referenced
this pull request
Jan 3, 2019
Fixes: ceph/ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com> (cherry picked from commit 867940e08bd829bbe16cb23ae4337b56e00ff9a6)
neha-ojha
pushed a commit
to neha-ojha/ceph
that referenced
this pull request
Jan 4, 2019
Fixes: ceph#24308 Signed-off-by: Yuri Weinstein <yweinste@redhat.com> (cherry picked from commit 867940e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/36274
This is a backport of #23317
https://tracker.ceph.com/issues/36239