Skip to content

tools/rados/rados.cc: fix rados rm --force-full blocking problem#24264

Merged
liewegas merged 1 commit intoceph:masterfrom
yanghonggang:master
Oct 11, 2018
Merged

tools/rados/rados.cc: fix rados rm --force-full blocking problem#24264
liewegas merged 1 commit intoceph:masterfrom
yanghonggang:master

Conversation

@yanghonggang
Copy link
Contributor

@gregsfortytwo
Copy link
Member

Hmm, it seems like FULL_TRY shouldn't be necessary for this to work; do we have a conditional somewhere that checks FULL_TRY and not FULL_FORCE?

@gregsfortytwo
Copy link
Member

Hmm, it seems like FULL_TRY shouldn't be necessary for this to work; do we have a conditional somewhere that checks FULL_TRY and not FULL_FORCE?

(Also: jenkins retest this please)

@xiexingguo
Copy link
Member

xiexingguo commented Oct 8, 2018

Hmm, it seems like FULL_TRY shouldn't be necessary for this to work; do we have a conditional somewhere that checks FULL_TRY and not FULL_FORCE?

https://github.com/ceph/ceph/blob/master/src/osd/PrimaryLogPG.cc#L2052
Seems we use FULL_TRY for unconditional removals, even if we are failsafe_full

@gregsfortytwo
Copy link
Member

Can we fix that as well @yanghonggang so this doesn't bite future devs as well?

@xiexingguo
Copy link
Member

Can we fix that as well @yanghonggang so this doesn't bite future devs as well?

@gregsfortytwo I don't think so. See #17177 for the details.

@liewegas liewegas merged commit 3d2b994 into ceph:master Oct 11, 2018
liewegas added a commit that referenced this pull request Oct 11, 2018
* refs/pull/24264/head:
	tools/rados/rados.cc: fix rados rm --force-full blocking problem

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants