Skip to content

objclass-sdk: expose __cls_init() to the world#21581

Merged
liewegas merged 1 commit intoceph:masterfrom
tchaikov:wip-objcls-sdk
Apr 23, 2018
Merged

objclass-sdk: expose __cls_init() to the world#21581
liewegas merged 1 commit intoceph:masterfrom
tchaikov:wip-objcls-sdk

Conversation

@tchaikov
Copy link
Copy Markdown
Contributor

@tchaikov tchaikov commented Apr 21, 2018

the __cls_init() function should be visible. otherwise we cannot call it
to register the cls methods

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added this to the mimic milestone Apr 21, 2018
@tchaikov tchaikov requested review from jdurgin and neha-ojha April 21, 2018 08:44
@tchaikov
Copy link
Copy Markdown
Contributor Author

tchaikov commented Apr 21, 2018 •
edited
Loading

this regression was introduced by #21571

it should address failures like http://pulpito.ceph.com/kchai-2018-04-21_06:05:10-rados-wip-kefu-testing-2018-04-21-0943-distro-basic-smithi/2424825/

@tchaikov
objclass-sdk: expose __cls_init() to the world
096668e 
the __cls_init() function should be visible. otherwise we cannot call it
to register the cls methods

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
Copy link
Copy Markdown
Contributor Author

tchaikov commented Apr 21, 2018 •
edited
Loading

being tested at

@tchaikov
Copy link
Copy Markdown
Contributor Author

tchaikov commented Apr 21, 2018

tchaikov
tchaikov commented Apr 22, 2018
View reviewed changes
src/objclass/objclass.h

struct obj_list_watch_response_t;

#if __GNUC__ >= 4
Copy link
Copy Markdown
Contributor Author

@tchaikov tchaikov Apr 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dropped this check, because GCC-7 is required to build ceph now.

This was referenced Apr 23, 2018
Merged
Merged
Merged
Merged
Merged
@tchaikov
Copy link
Copy Markdown
Contributor Author

tchaikov commented Apr 23, 2018

@liewegas @jdurgin i have run this PR though rados qa suite. and it's good to merge once it's blessed by reviewers.

@liewegas liewegas merged commit 25d754a into ceph:master Apr 23, 2018
@tchaikov tchaikov deleted the wip-objcls-sdk branch April 23, 2018 13:51
@dillaman
Copy link
Copy Markdown

dillaman commented Apr 23, 2018

FYI -- My local build fails since WITH_EMBEDDED defaults to ON and cephd_cls_base fails to compile.

@tchaikov
Copy link
Copy Markdown
Contributor Author

tchaikov commented Apr 23, 2018 •
edited
Loading

@dillaman but it passed jenkins' "make check" run, where WITH_EMBEDDED is also ON, see https://jenkins.ceph.com/job/ceph-pull-requests/45067

@dillaman
Copy link
Copy Markdown

dillaman commented Apr 23, 2018 •
edited
Loading

@tchaikov Check the log -- it doesn't actually build cephd_cls_base

@tchaikov
Copy link
Copy Markdown
Contributor Author

tchaikov commented Apr 23, 2018

@dillaman ahh, right! it just "make tests"! will take a closer look tomorrow morning.

@dillaman
Copy link
Copy Markdown

dillaman commented Apr 23, 2018

@tchaikov Gotcha, cool -- I couldn't immediately figure out the difference between my environment and jenkins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liewegas liewegas liewegas approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees

No one assigned

Labels

bug-fix needs-review wip-kefu-testing wip-sage3-testing

Projects

None yet

Milestone

mimic

Development

Successfully merging this pull request may close these issues.

3 participants

@tchaikov @dillaman @liewegas