cmake: hide symbols import from other libraries in libcls_*#21571
Merged
dillaman merged 1 commit intoceph:masterfrom Apr 20, 2018
Merged
cmake: hide symbols import from other libraries in libcls_*#21571dillaman merged 1 commit intoceph:masterfrom
dillaman merged 1 commit intoceph:masterfrom
Conversation
so they will not be involved when resolving symbols. ld tries to keep a shared library around even if it fails to load it if it offers some unique symbols. in that case, the library will not be properly unloaded, and even worse it will interfere with following dlopen() calls, because it is marked with NODELETE by dlopen(). if it has some unresolved symbol and does offer some "unique" symbols required by the library to be loaded, the library will fail to load, despite the fact that the "unique" symbol is also offered by the executable. for more details, see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60731 and https://sourceware.org/bugzilla/show_bug.cgi?id=14577 Fixes: http://tracker.ceph.com/issues/23517 Signed-off-by: Kefu Chai <kchai@redhat.com>
cbodley
approved these changes
Apr 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so they will not be involved when resolving symbols. ld tries to
keep a shared library around even if it fails to load it if it offers
some unique symbols. in that case, the library will not be properly
unloaded, and even worse it will interfere with following dlopen()
calls, because it is marked with NODELETE by dlopen(). if it has some
unresolved symbol and does offer some "unique" symbols required by
the library to be loaded, the library will fail to load, despite the
fact that the "unique" symbol is also offered by the executable.
for more details, see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60731 and
https://sourceware.org/bugzilla/show_bug.cgi?id=14577
Fixes: http://tracker.ceph.com/issues/23517
Signed-off-by: Kefu Chai kchai@redhat.com