os/bluestore/BlueFS: compact log even when sync_metadata sees no work#17354
Merged
liewegas merged 1 commit intoceph:masterfrom Aug 31, 2017
Merged
os/bluestore/BlueFS: compact log even when sync_metadata sees no work#17354liewegas merged 1 commit intoceph:masterfrom
liewegas merged 1 commit intoceph:masterfrom
Conversation
It's possible that when sync_metadata() is called there won't be any new log data to flush because it was already flushed for other reasons (e.g., because fsync was called). However, the log may still be large and in need of compaction. Signed-off-by: Sage Weil <sage@redhat.com>
xiexingguo
approved these changes
Aug 30, 2017
Member
xiexingguo
left a comment
There was a problem hiding this comment.
yeah, I see the discussion on ceph-dev channel.
Make sense!
runsisi
pushed a commit
to runsisi/ceph
that referenced
this pull request
Mar 20, 2018
os/bluestore: ceph#17354; ceph#17627; ceph#17684 See merge request clove/ceph!251
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible that when sync_metadata() is called there won't be any new
log data to flush because it was already flushed for other reasons (e.g.,
because fsync was called). However, the log may still be large and in
need of compaction.
Signed-off-by: Sage Weil sage@redhat.com