librados: set the flag CEPH_OSD_FLAG_FULL_TRY of Op in the right place.#14193
Merged
tchaikov merged 1 commit intoceph:masterfrom Apr 1, 2017
liupan1111:wip-fix-delete-full
Merged
librados: set the flag CEPH_OSD_FLAG_FULL_TRY of Op in the right place.#14193tchaikov merged 1 commit intoceph:masterfrom liupan1111:wip-fix-delete-full
tchaikov merged 1 commit intoceph:masterfrom
liupan1111:wip-fix-delete-full
Conversation
Signed-off-by: Pan Liu <liupan1111@gmail.com>
Contributor
Author
|
@dillaman , please help take a look, thanks. |
liewegas
approved these changes
Mar 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the incompletely bug fix for my code added in #12627.
In 12627, I set CEPH_OSD_FLAG_FULL_TRY flag in _prepare_osd_op, which was too late for pause check. But because of the bug ( now fixed in #13425), I thought OSD was full, but indeed it was not, therefore, my last change didn't work, which case I didn't realize that at that time.