qa/tasks/workunit.py: use "overrides" as the default settings of workunit#14281
Merged
tchaikov merged 1 commit intoceph:masterfrom Apr 5, 2017
Merged
qa/tasks/workunit.py: use "overrides" as the default settings of workunit#14281tchaikov merged 1 commit intoceph:masterfrom
tchaikov merged 1 commit intoceph:masterfrom
Conversation
Contributor
Author
|
tested at http://pulpito.ceph.com/kchai-2017-04-01_16:57:29-rados-master---basic-mira/ using |
This was referenced Apr 1, 2017
…unit otherwise the settings in "workunit" tasks are always overridden by the settings in template config. so we'd better follow the way of how "install" task updates itself with the "overrides" settings: it uses the "overrides" as the *defaults*. Fixes: http://tracker.ceph.com/issues/19429 Signed-off-by: Kefu Chai <kchai@redhat.com>
Contributor
Author
|
@yuriw this is the fix for one of the known test failures. |
Contributor
Author
jdurgin
approved these changes
Apr 4, 2017
Member
jdurgin
left a comment
There was a problem hiding this comment.
Looks good! This is the way I thought it always worked...
|
Related to issue ceph/teuthology#1055 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise the settings in "workunit" tasks are always overridden by the
settings in template config. so we'd better follow the way of how
"install" task updates itself with the "overrides" settings: it uses the
"overrides" as the defaults.
Fixes: http://tracker.ceph.com/issues/19429
Signed-off-by: Kefu Chai kchai@redhat.com