prefer prefix ++/--operator for e.g. iterators for performance reasons#110
Closed
dalgaaf wants to merge 36 commits intoceph:masterfrom
dalgaaf:wip-da-performance-2
Closed
prefer prefix ++/--operator for e.g. iterators for performance reasons#110dalgaaf wants to merge 36 commits intoceph:masterfrom dalgaaf:wip-da-performance-2
dalgaaf wants to merge 36 commits intoceph:masterfrom
dalgaaf:wip-da-performance-2
Conversation
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Prefer prefix ++operator for iterators, move one iterator declaration into the for-loop header, since the iterator is only used within the loop. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Prefer prefix ++operator for iterators, move some iterator declaration into the for-loop header, since the iterator is only used within the loops. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Prefer prefix ++operator for iterators, move some iterator declaration into the for-loop header, since the iterator is only used within the loop. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Add bound check for ++range_iter in clone_objs_impl(), since range_iter gets incremented in loop header and inside the loop. Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Member
|
Can you drop that hunk/patch and resubmit? Thanks! |
chamdoo
pushed a commit
to chamdoo/ceph
that referenced
this pull request
Nov 13, 2015
[JNI] Add JNI bindings for rocksdb Options
liewegas
added a commit
that referenced
this pull request
Dec 14, 2016
Moved mon.c to teh first host with mon.a and mon.b to address the issue ...
ddiss
pushed a commit
to ddiss/ceph
that referenced
this pull request
May 9, 2017
build/ops: rpm: install python-six in build environment Reviewed-by: Ricardo Dias <rdias@suse.com>
3 tasks
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 5, 2021
Favicon asset path.
galsalomon66
referenced
this pull request
in galsalomon66/ceph
Sep 17, 2022
* - instead of copy string from scratch-area into star-operation-buffer, use a reference to values - remove redundant data-member"s (reduce object size) * - add test coverage for star-operation, check results against input, and compare results of CSV vs Parquet Signed-off-by: gal salomon <gal.salomon@gmail.com>
m-ildefons
added a commit
to m-ildefons/ceph
that referenced
this pull request
Feb 24, 2023
ci: run s3tests
tobias-urdin
pushed a commit
to tobias-urdin/ceph
that referenced
this pull request
Aug 2, 2023
rgw: add a new multipart test Reviewed-by: Orit Wasserman <owasserm@redhat.com>
kshtsk
pushed a commit
to kshtsk/ceph
that referenced
this pull request
Aug 14, 2024
common/options: Reduce rgw_thread_pool_size.
Moisi
pushed a commit
to Moisi/ceph
that referenced
this pull request
Jun 30, 2025
Merge in STORAGEENG/ceph from CEPH-216-migrate-all-new-changes-from-v17-to-v18 to aka_version_18.2.1 * commit '6733cf428e5dee9405de4c0501bb1cd96ddd4b25': CEPH-205: Make copy source bucket attrs available for permission verification CEPH-202 osd_debug CEPH-54 common_prefixes are missing in list multipart requests CEPH-156 OSD Debug tool JIRA: https://track.akamai.com/jira/browse/CEPH-174 OBJGEN1-1047 Explicit Null Termination of memory_buffer used to log into alog_dpp OBJGEN1-1047-ceph-life-cycle-policy-should-report-delete-status OBJGEN1-1235 This script can detect and delete incomplete MPUs. OBJGEN1-1235-ceph-bucket-lifecycle-scan-tool-improvement OBJGEN1-950-ceph-report-rgw-concurrent-connection-or-other-data-to-sre
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new bunch of performance related changes from postfix to prefix ++/--operator for e.g. iterators.
Includes two fixes for: