Skip to content

ARM64 fixes#10438

Merged
tchaikov merged 3 commits intomasterfrom
wip-arm64
Jul 27, 2016
Merged

ARM64 fixes#10438
tchaikov merged 3 commits intomasterfrom
wip-arm64

Conversation

@dmick
Copy link
Member

@dmick dmick commented Jul 26, 2016

Three things to fix build on arm64. The changes for jerasure and test should not affect x86, but the rocksdb update certainly might; marking needs-qa because of that.

(We need a CI builder for arm64. Something happened to the Cavium-supplied gitbuilder and I'm not sure what.)

dmick added 3 commits July 25, 2016 20:05
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Fixes ARM64 build of ceph_perf_local test

Signed-off-by: Dan Mick <dan.mick@redhat.com>
Signed-off-by: Dan Mick <dan.mick@redhat.com>
@dmick dmick added the needs-qa label Jul 26, 2016
@tchaikov
Copy link
Contributor

@tone-zhang maybe you could try this PR to see if it works for you?

@tone-zhang
Copy link
Contributor

@tchaikov No problem, I will double verify the PR in my AArch64 platform.

@cbodley
Copy link
Contributor

cbodley commented Jul 26, 2016

👍

@alimaredia
Copy link
Contributor

lgtm. once this is verified someone go ahead and merge it!

@dmick
Copy link
Member Author

dmick commented Jul 26, 2016

Reemphasizing this should see a fullish qa run because it's updating rocksdb. I'm a noob in current process so if I need to do something other than mark needs-qa, let me know before merging. I could schedule a suite of some sort at least?

@dmick
Copy link
Member Author

dmick commented Jul 26, 2016

ah, I also hadn't realized there was a lot of duplicated work in #10427; sorry about that.

@tchaikov
Copy link
Contributor

@tone-zhang how is your test going, does this PR work for you?

@tone-zhang
Copy link
Contributor

@tchaikov Kefu, sorry for the late, the test bed in our side is very busy.
I take the update in the PR, and build the Ceph locally, the build has been passed.

@tchaikov
Copy link
Contributor

tchaikov commented Jul 27, 2016

@tone-zhang thanks for testing! as your change actually depends on this one. so we'd better get it merged before yours.

@tchaikov
Copy link
Contributor

tchaikov commented Jul 27, 2016

if I need to do something other than mark needs-qa, let me know before merging. I could schedule a suite of some sort at least?

@dmick rocksdb is used by bluestore, and is used as an optional backend of our kv store, which is in turn "leveldb" by default. we don't have qa suite exercising the bluestore atm, but the rados test suite is using rocksdb backend. i will run your branch through it.

@tone-zhang
Copy link
Contributor

@tchaikov Kefu, all right. After the merge, I will continue the PR #10427 if there was anything left.

@tchaikov
Copy link
Contributor

tchaikov commented Jul 27, 2016

being tested at http://pulpito.ceph.com/kchai-2016-07-27_00:28:21-rados-wip-arm64---basic-mira/ with --filter="rocksdb.yaml"

@tchaikov tchaikov merged commit e93f25c into master Jul 27, 2016
@tchaikov tchaikov deleted the wip-arm64 branch July 27, 2016 15:52
@dmick
Copy link
Member Author

dmick commented Jul 28, 2016

tnx @tchaikov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants