Conversation
Signed-off-by: Dan Mick <dan.mick@redhat.com>
Fixes ARM64 build of ceph_perf_local test Signed-off-by: Dan Mick <dan.mick@redhat.com>
Signed-off-by: Dan Mick <dan.mick@redhat.com>
|
@tone-zhang maybe you could try this PR to see if it works for you? |
|
@tchaikov No problem, I will double verify the PR in my AArch64 platform. |
|
👍 |
|
lgtm. once this is verified someone go ahead and merge it! |
|
Reemphasizing this should see a fullish qa run because it's updating rocksdb. I'm a noob in current process so if I need to do something other than mark needs-qa, let me know before merging. I could schedule a suite of some sort at least? |
|
ah, I also hadn't realized there was a lot of duplicated work in #10427; sorry about that. |
|
@tone-zhang how is your test going, does this PR work for you? |
|
@tchaikov Kefu, sorry for the late, the test bed in our side is very busy. |
|
@tone-zhang thanks for testing! as your change actually depends on this one. so we'd better get it merged before yours. |
@dmick rocksdb is used by bluestore, and is used as an optional backend of our kv store, which is in turn "leveldb" by default. we don't have qa suite exercising the bluestore atm, but the rados test suite is using rocksdb backend. i will run your branch through it. |
|
being tested at http://pulpito.ceph.com/kchai-2016-07-27_00:28:21-rados-wip-arm64---basic-mira/ with |
|
tnx @tchaikov |
Three things to fix build on arm64. The changes for jerasure and test should not affect x86, but the rocksdb update certainly might; marking needs-qa because of that.
(We need a CI builder for arm64. Something happened to the Cavium-supplied gitbuilder and I'm not sure what.)