Conversation
|
@tone-zhang you might be interested in this change. 7818d91 it's what we've been talking about. |
|
@tchaikov Kefu, yes, it is the update in rocksdb which we need. Thanks. |
|
this change looks good to me, @alimaredia what do you think? |
| target_link_libraries(ec_jerasure_sse3 crush ${EXTRALIBS}) | ||
| set_target_properties(ec_jerasure_sse3 PROPERTIES VERSION 2.0.0 SOVERSION 2 | ||
| COMPILE_FLAGS ${SSE3_FLAGS}) | ||
| COMPILE_FLAGS ${COMPILE_TARGETS_FLAGS}) |
There was a problem hiding this comment.
this doesn't look right to me. we only want to pass supported sse3 flags for this target, not all supported flags
There was a problem hiding this comment.
@cbodley Casey, thanks, I will roll back the code and use sse3 flags as origin.
|
I like how you moved the detection stuff into a module, but we need to keep the flags separated instead of combining them all into |
02453ed to
cd500c5
Compare
|
@tone-zhang #10438 is competing with your PR, and it got merged first. if you'd like to continue working on this PR, we can still have the first commit for refactoring the compiler detection. |
|
@tchaikov Kefu, I will continue on the first. Thanks! |
|
@tone-zhang From my personal experience with Pulls this large is that that is not going to work. There is no ill will with the commiters, but the code is mostly changing so rapidly that with 72 files being modified in one pull there is an almost 100% chance that your pull has something to discuss about. So I personally have moved to smaller commits, with less files changed in one run. Chances of getting such a pull commited are way much bigger. And in the end you will get more commited. Just my 2 cts. |
|
@wjwithagen Willem, it is my fault. I just commit two files I updated, but contain so many non-related commits which are the delta between my working branch and ceph/master. I need more practice to familiar with git commands. Apologize for the mess. |
The PR comes from #10311, because the origin one is in a mess.
Reconstruct the cmake files, extrace one common module from src/CMakeLists.txt.
And update the related CMakeLists.txt files.
When compile the Ceph UT, because the -msse and -msse2 are hardcoded in
the test/CMakeLists.txt, the Ceph UT build fail in AArm64. Fix the issue.
Signed-off-by: tone.zhang tone.zhang@linaro.org