This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Implement TelemetryProcessors for Azure exporters#851
Merged
lzchen merged 14 commits intocensus-instrumentation:masterfrom Jan 29, 2020
Merged
Implement TelemetryProcessors for Azure exporters#851lzchen merged 14 commits intocensus-instrumentation:masterfrom
lzchen merged 14 commits intocensus-instrumentation:masterfrom
Conversation
hectorhdzg
reviewed
Jan 27, 2020
hectorhdzg
reviewed
Jan 27, 2020
hectorhdzg
reviewed
Jan 27, 2020
contrib/opencensus-ext-azure/opencensus/ext/azure/common/processor.py
Outdated
Show resolved
Hide resolved
c24t
approved these changes
Jan 28, 2020
Member
c24t
left a comment
There was a problem hiding this comment.
LGTM, but I'd like to see a test of callbacks that actually modify the envelope.
The example prose changes look good, but you may want to rearrange the text so it doesn't explain exporter callbacks three times.
| - Process CPU Usage (percentage) | ||
| - Process Private Bytes (bytes) | ||
|
|
||
| You can pass a callback function to the exporter to process telemetry before it is exported. Your callback function can return `False` if you do not want this envelope exported. Your callback function must |
Contributor
Author
There was a problem hiding this comment.
It's fine having the text duplicated, we have duplicate documentation for creating an Azure Monitor resource and how to instrument with the instrumentation_key for each section. Usually users come to this page looking for a specific section (either trace, metrics or logs) so this shouldn't be a eyesore.
| with tracer.span(name='parent'): | ||
| response = requests.get(url='https://www.wikipedia.org/wiki/Rabbit') | ||
|
|
||
| You can pass a callback function to the exporter to process telemetry before it is exported. Your callback function can return `False` if you do not want this envelope exported. Your callback function must |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement TelemetryProcessors for Azure Exporters.
TelemetryProcessors allow users to define a callback function to modify the envelopes before they are sent to the Azure Monitor backend. They can also be used to omit envelopes from being exported. Refer to the
READMEon how users can do this and what the schema for the payloads look like.See this article on how other SDKs are doing this in other languages for Azure Monitor.