Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Allow installing opencensus-ext-django with Django 2.0 and later #697

Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom
timgraham:install-with-new-django
Jun 28, 2019
Merged

Allow installing opencensus-ext-django with Django 2.0 and later #697
songy23 merged 2 commits intocensus-instrumentation:masterfrom
timgraham:install-with-new-django

Conversation

@timgraham
Copy link
Copy Markdown
Contributor

Fixes #538

@timgraham timgraham requested review from a team, c24t, reyang and songy23 as code owners June 28, 2019 01:17
@songy23 songy23 merged commit 4c4957c into census-instrumentation:master Jun 28, 2019
@timgraham timgraham deleted the install-with-new-django branch July 1, 2019 01:52
@tstirrat15
Copy link
Copy Markdown

When will this be available?

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Jul 25, 2019

We plan to have a release at end of this month.

@tstirrat15
Copy link
Copy Markdown

Hmm. Is that because it's a multirepo?

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Jul 25, 2019

Not sure if I understand what is multirepo, would you elaborate?

@tstirrat15
Copy link
Copy Markdown

This repository has multiple python packages. Do they all have to be released at the same time?

I'm trying to understand why the relatively small number of changes in the ext-django package can't be released earlier.

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Jul 25, 2019

Technically we can, and we have done multiple minor releases for contrib packages before.
Each package can be released individually.

Going forward we're trying to have a period release for features, and on demand release for bug fixes.

@tstirrat15
Copy link
Copy Markdown

Gotcha. May I suggest that this be considered a bug fix? This is blocking an upgrade to Django 2 for us.

@tstirrat15
Copy link
Copy Markdown

Unless the release is going to happen in the next five days, in which case that's fine. I wasn't thinking about what "end of the month" meant when you said that.

@reyang reyang mentioned this pull request Jul 26, 2019
@reyang
Copy link
Copy Markdown
Contributor

reyang commented Jul 26, 2019

@tstirrat15 Here you go https://pypi.org/project/opencensus-ext-django/0.3.2/.
Let us know if you encounter any issues. Thanks.

@tstirrat15
Copy link
Copy Markdown

It worked perfectly. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the latest version of Django

5 participants