This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Fix span batching to stackdriver#425
Merged
bogdandrutu merged 3 commits intocensus-instrumentation:masterfrom Dec 6, 2018
Merged
Fix span batching to stackdriver#425bogdandrutu merged 3 commits intocensus-instrumentation:masterfrom
bogdandrutu merged 3 commits intocensus-instrumentation:masterfrom
Conversation
Member
|
@kornholi is this fixing a regression in the stackdriver exporter or an improvement? |
Contributor
Author
|
Regression from #291 |
c24t
reviewed
Dec 5, 2018
Member
c24t
left a comment
There was a problem hiding this comment.
LGTM, please file a ticket for the stackdriver quota issue (instead of the FIXME comment) if this is still causing problems for you.
| trace = span_data.format_legacy_trace_json(sds) | ||
| stackdriver_spans = self.translate_to_stackdriver(trace) | ||
| self.client.batch_write_spans(project, stackdriver_spans) | ||
| stackdriver_spans.extend(self.translate_to_stackdriver(trace)) |
Member
There was a problem hiding this comment.
Out of curiosity: why change this to a generator if you're just appending the results?
Contributor
Author
There was a problem hiding this comment.
to avoid intermediate lists
c24t
approved these changes
Dec 5, 2018
c24t
pushed a commit
to c24t/opencensus-python
that referenced
this pull request
Jan 16, 2019
* Fix span batching to stackdriver * Lose FIXME comment
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently every trace is being exported individually, burning through Stackdriver quota.
This change was deployed at 5:46 PM.
@c24t @liyanhui1228 could you take a look?