This repository was archived by the owner on Sep 17, 2025. It is now read-only.
[Fixes #270] Make BackgroundThread more resilient to exceptions#297
Merged
liyanhui1228 merged 12 commits intocensus-instrumentation:masterfrom Sep 12, 2018
Merged
Conversation
Contributor
|
LGTM, we will also need to add unit test for that to ensure 100% test coverage. |
Contributor
|
Thanks! Maybe exclude the "after max retries" part as it depends on the actual exporter? |
Contributor
Author
|
@kornholi done |
This was referenced Sep 8, 2018
liyanhui1228
approved these changes
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just add a try/except/pass to the AsyncTransport and the BackgroundThread, thus allowing the thread to remain alive when something bad happens with the exporter.
This fixes #270