Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Checker Framework: 2.6.0 -> 2.7.0#1792

Merged
sebright2 merged 1 commit intocensus-instrumentation:masterfrom
sebright2:upgrade-checker-framework
Mar 8, 2019
Merged

Checker Framework: 2.6.0 -> 2.7.0#1792
sebright2 merged 1 commit intocensus-instrumentation:masterfrom
sebright2:upgrade-checker-framework

Conversation

@sebright2
Copy link
Copy Markdown
Contributor

@sebright2 sebright2 commented Mar 8, 2019

This commit also fixes some new warnings by removing raw types and uncommenting
some Nullable annotations that didn't need to be commented.

@sebright2
Checker Framework: 2.6.0 -> 2.7.0
7715974 
This commit also fixes some new warnings by removing raw types and uncommenting
some Nullable annotations that didn't need to be commented.
@sebright2 sebright2 requested review from rghetia and songy23 March 8, 2019 19:50
@sebright2 sebright2 requested review from a team and dinooliva as code owners March 8, 2019 19:50
songy23
songy23 approved these changes Mar 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebright2 sebright2 merged commit b4c9db4 into census-instrumentation:master Mar 8, 2019
@sebright2 sebright2 deleted the upgrade-checker-framework branch March 8, 2019 20:38
sebright2 added a commit to sebright2/opencensus-java that referenced this pull request Mar 8, 2019
@sebright2
Remove package qualification from Immutable annotations.
d156fd6 
Upgrading to Checker Framework 2.7.0 in census-instrumentation#1792 seemed to fix issue census-instrumentation#1782, so this
commit removes the unnecessary package qualification.

Fixes census-instrumentation#1782.
@sebright2 sebright2 mentioned this pull request Mar 8, 2019
Merged
sebright2 added a commit that referenced this pull request Mar 8, 2019
@sebright2
Remove package qualification from Immutable annotations. (#1793)
e4ce56b 
Upgrading to Checker Framework 2.7.0 in #1792 seemed to fix issue #1782, so this
commit removes the unnecessary package qualification.

Fixes #1782.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rghetia rghetia Awaiting requested review from rghetia

@dinooliva dinooliva Awaiting requested review from dinooliva

1 more reviewer

@songy23 songy23 songy23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rghetia rghetia

@songy23 songy23

Labels

cla: yes static analysis

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebright2 @songy23 @googlebot @rghetia