Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Exemplar: Record with sampled SpanContext in gRPC plugin.#1127

Merged
songy23 merged 1 commit intocensus-instrumentation:devfrom
songy23:update-grpc-plugin
Apr 24, 2019
Merged

Exemplar: Record with sampled SpanContext in gRPC plugin.#1127
songy23 merged 1 commit intocensus-instrumentation:devfrom
songy23:update-grpc-plugin

Conversation

@songy23
Copy link
Copy Markdown
Contributor

@songy23 songy23 commented Apr 23, 2019

Whenever there's a sampled span in a RPC, record it as an exemplar attachment.

Fixes #1058.

Copy link
Copy Markdown
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 merged commit 5d45ada into census-instrumentation:dev Apr 24, 2019
@songy23 songy23 deleted the update-grpc-plugin branch April 24, 2019 23:37
rghetia pushed a commit to rghetia/opencensus-go that referenced this pull request Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants