Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Add description field to LabelKey#1114

Merged
rghetia merged 2 commits intocensus-instrumentation:devfrom
rghetia:label_key_desc
Apr 18, 2019
Merged

Add description field to LabelKey#1114
rghetia merged 2 commits intocensus-instrumentation:devfrom
rghetia:label_key_desc

Conversation

@rghetia
Copy link
Copy Markdown
Contributor

@rghetia rghetia commented Apr 18, 2019 •
edited
Loading

This fixes #1063.

This is a breaking change. The only user of the LabelKey is stackdriver exporter and prometheus exporter. Prometheus exporter is handled as part of this commit. PR for SD change is opened.

@rghetia rghetia requested review from a team and rakyll as code owners April 18, 2019 05:00
@rghetia rghetia mentioned this pull request Apr 18, 2019
Merged
songy23
songy23 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI.

metric/registry.go Outdated
return func(mo *metricOptions) {
labelKeys := make([]metricdata.LabelKey, 0)
for _, key := range keys {
labelKeys = append(labelKeys, metricdata.LabelKey{Key: key, Description: key})
Copy link
Copy Markdown
Contributor

@songy23 songy23 Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leaving Description empty.

Copy link
Copy Markdown
Contributor Author

@rghetia rghetia Apr 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@rghetia
Copy link
Copy Markdown
Contributor Author

rghetia commented Apr 18, 2019

Please fix CI.

@songy23, I don't think failure is related to the change. can you please confirm?

@songy23
Copy link
Copy Markdown
Contributor

songy23 commented Apr 18, 2019 

# runtime
C:\go\src\runtime\cpuflags_amd64.go:14:2: offsetX86HasAVX2 redeclared in this block
	previous declaration at C:\go\src\runtime\cpuflags.go:14:37
C:\go\src\runtime\mem_windows.go:27:6: sysAlloc redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:14:43
C:\go\src\runtime\mem_windows.go:32:6: sysUnused redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:32:36
C:\go\src\runtime\mem_windows.go:62:6: sysUsed redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:36:34
C:\go\src\runtime\mem_windows.go:87:6: sysFree redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:42:52
C:\go\src\runtime\mem_windows.go:96:6: sysFault redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:48:35
C:\go\src\runtime\mem_windows.go:101:6: sysReserve redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:52:46
C:\go\src\runtime\mem_windows.go:114:6: sysMap redeclared in this block
	previous declaration at C:\go\src\runtime\mem_aix.go:60:51
C:\go\src\runtime\netpoll_windows.go:36:6: netpollinit redeclared in this block
	previous declaration at C:\go\src\runtime\netpoll_aix.go:55:6
C:\go\src\runtime\netpoll_windows.go:44:6: netpolldescriptor redeclared in this block
	previous declaration at C:\go\src\runtime\netpoll_aix.go:90:26
C:\go\src\runtime\netpoll_windows.go:44:6: too many errors

Seems to be related to the Windows host.

@rghetia rghetia merged commit f67cd4b into census-instrumentation:dev Apr 18, 2019
@rghetia rghetia deleted the label_key_desc branch April 18, 2019 21:38
rghetia added a commit to rghetia/opencensus-go that referenced this pull request Apr 25, 2019
@rghetia
Add description field to LabelKey (census-instrumentation#1114)
2641c9f 
* Add description field to LabelKey

* keep description as "" when not specified.
rghetia added a commit that referenced this pull request Apr 25, 2019
@rghetia
Add description field to LabelKey (#1114)
4651f24 
* Add description field to LabelKey

* keep description as "" when not specified.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rakyll rakyll Awaiting requested review from rakyll

1 more reviewer

@songy23 songy23 songy23 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rghetia @songy23