This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Refactor gauge and registry to accommodate cumulative.#1089
Merged
rghetia merged 2 commits intocensus-instrumentation:devfrom Apr 3, 2019
Merged
Refactor gauge and registry to accommodate cumulative.#1089rghetia merged 2 commits intocensus-instrumentation:devfrom
rghetia merged 2 commits intocensus-instrumentation:devfrom
Conversation
- use common baseMetric type to manage gauge and cumulative.
songy23
approved these changes
Apr 3, 2019
metric/common.go
Outdated
| @@ -0,0 +1,126 @@ | |||
| // Copyright 2018, OpenCensus Authors | |||
metric/common.go
Outdated
| return m | ||
| } | ||
|
|
||
| func (bm *baseMetric) mapKey(labelVals []metricdata.LabelValue) string { |
Contributor
There was a problem hiding this comment.
Nit: consider calling this encodeLabelVals for better readability.
metric/common.go
Outdated
| return string(vb.Bytes()) | ||
| } | ||
|
|
||
| func (bm *baseMetric) labelValues(s string) []metricdata.LabelValue { |
Contributor
There was a problem hiding this comment.
Same, consider decodeLabelVals.
rghetia
added a commit
to rghetia/opencensus-go
that referenced
this pull request
Apr 25, 2019
…mentation#1089) * Refactor gauge and registry to accomodate cummulative. - use common baseMetric type to manage gauge and cumulative. * fix copyright and renamed couple of func.
rghetia
added a commit
that referenced
this pull request
Apr 25, 2019
* Refactor gauge and registry to accomodate cummulative. - use common baseMetric type to manage gauge and cumulative. * fix copyright and renamed couple of func.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be followed by a PR for cumulative support.