This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Exemplar: Use generic interface for attachment values.#1070
Merged
songy23 merged 2 commits intocensus-instrumentation:masterfrom Mar 20, 2019
Merged
Exemplar: Use generic interface for attachment values.#1070songy23 merged 2 commits intocensus-instrumentation:masterfrom
songy23 merged 2 commits intocensus-instrumentation:masterfrom
Conversation
rghetia
reviewed
Mar 18, 2019
Contributor
rghetia
left a comment
There was a problem hiding this comment.
couple of nits. Otherwise LGTM.
stats/view/aggregation_data.go
Outdated
| CountPerBucket []int64 // number of occurrences per bucket | ||
| // ExemplarsPerBucket is slice the same length as CountPerBucket containing | ||
| // an metricdata for the associated bucket, or nil. | ||
| // an emexplar for the associated bucket, or nil. |
Contributor
There was a problem hiding this comment.
typo. s/emexplar/exemplar/
stats/view/aggregation_data_test.go
Outdated
| dd := newDistributionData([]float64{1, 2}) | ||
| dd.addSample(0.5) | ||
| attachments1 := map[string]interface{}{"key1": "value1"} | ||
| t1, _ := time.Parse("Mon Jan 2 15:04:05 -0700 MST 2006", "Mon Jan 2 15:04:05 -0700 MST 2006") |
Contributor
There was a problem hiding this comment.
nit: time.Now() should work.
rghetia
approved these changes
Mar 18, 2019
Contributor
Author
|
FYI this PR doesn't contain user-visible changes. Will merge by EOD today if there're no other comments/concerns. |
songy23
added a commit
that referenced
this pull request
Apr 3, 2019
(cherry picked from commit 8a36f74)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #1058.
Similar to Java PR census-instrumentation/opencensus-java#1779. Though in Go I think we can take advantage of the flexibility on
interfaces so I just usedinterface{}for generic attachment values. WDYT?