Fix issue causing update-geth.sh fails#318
Closed
Kourin1996 wants to merge 1 commit intocelo-rebase-12from
Closed
Conversation
Author
|
@piersy Do you think if any processes for |
palango
reviewed
Feb 13, 2025
| if [ "$(perl -ne "m|${docker_search_string}| && print" ops-bedrock/l2-op-geth.Dockerfile | wc -l)" != "1" ]; then | ||
| echo "Failed to find exactly one match for docker search string in ops-bedrock/l2-op-geth.Dockerfile" >&2 | ||
| exit 1 | ||
| if [ -d "ops-bedrock" ]; then |
There was a problem hiding this comment.
Do we need this? I guess the ops-bedrock directory is not coming back.
Author
There was a problem hiding this comment.
@palango I'm just curious about that. We can remove any steps for ops-bedrock directory.
There was a problem hiding this comment.
There's now an optimism script that does the updating of the go.mod file, it's probably an improvement on the approach here because it uses go mod edit so I think we should use that. I've just been fiddling with it to see if it can work for us, I will raise a PR for that.
piersy
pushed a commit
that referenced
this pull request
Apr 8, 2025
* feat: interop fixes (#287) * feat: interop fixes * fix: natspec format * chore: add field on struct natspec --------- Co-authored-by: 0xDiscotech <131301107+0xDiscotech@users.noreply.github.com> * fix: campaign fixes (#313) * feat: interop fixes * fix: permit2 not inifinite approval check * chore: enhance superchain erc20 natspec * chore: tests natspec * fix: incorrect merge --------- Co-authored-by: agusduha <agusnduha@gmail.com> * chore: remove interop contracts (#318) * chore: remove unnecessary interop contracts * fix: golang tests * chore: remove system config interop and run pre pr * fix: exlude correct contracts on test to succeed * chore: update initializer array length * fix: semver lock * fix: L2 audit findings (#323) * fix: audit findings * chore: pre-pr * refactor: avoid stack too deep removing params on test (#324) --------- Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com> Co-authored-by: agusduha <agusnduha@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
ops/celo/update-geth.shandUpdate celo-org/op-gethaction fail incelo-rebase-12branch becauseops-bedrockdirectory no longer exists upstream after a PR ethereum-optimism#13842 was merged.This PR adds a check of existence of the directory for existing check.