[Audit - TOB-CELOL2-3] Add error checks to migration script#283
Merged
[Audit - TOB-CELOL2-3] Add error checks to migration script#283
Conversation
5aa3f84 to
005e3f1
Compare
palango
reviewed
Dec 10, 2024
piersy
reviewed
Dec 10, 2024
piersy
reviewed
Dec 10, 2024
piersy
reviewed
Dec 10, 2024
piersy
reviewed
Dec 10, 2024
piersy
reviewed
Dec 10, 2024
1011679 to
9a987d1
Compare
piersy
reviewed
Dec 11, 2024
6dc8642 to
158201a
Compare
palango
approved these changes
Dec 17, 2024
gastonponti
pushed a commit
that referenced
this pull request
Dec 17, 2024
* addresses audit comments * fix errors * addresses feedback * missed defer statements
jcortejoso
pushed a commit
that referenced
this pull request
Jan 10, 2025
* addresses audit comments * fix errors * addresses feedback * missed defer statements
karlb
pushed a commit
that referenced
this pull request
Feb 12, 2025
* addresses audit comments * fix errors * addresses feedback * missed defer statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/celo-org/celo-blockchain-planning/issues/845 based on audit feedback in TOB-CELOL2-3
Note that the suggestion to check if stray blocks are in the ancient db before removing them is not included here and may be added in a follow on. This change will be larger than those included here, and may have a performance impact that needs to be evaluated. We have also added a check to the migration script to ensure gaps do not exist in the block data (#282), which will help mitigate this concern as well.