Use name AbstractFeeCurrency to avoid confusion#188
Merged
Conversation
...with the FeeCurrency in celo/testing/FeeCurrency.sol . It also is a good idea to clearly name abstract contracts, so that nobody tries to use them as a non-abstract contract (e.g. tries a deployment).
palango
reviewed
Jul 3, 2024
| @@ -0,0 +1,354 @@ | |||
| [ | |||
There was a problem hiding this comment.
Why are this and the file containing the slots added? Shouldn't they at least be called AbstractFeeCurrency*?
Author
There was a problem hiding this comment.
These are for testing/FeeCurrency.sol, so the naming is fine. We don't need any for AbstractFeeCurrency as it can't be deployed anyway. I assume this file was missing before due to the name clash between the two contracts, but I didn't check how the snapshotting actually works.
palango
approved these changes
Jul 3, 2024
karlb
pushed a commit
that referenced
this pull request
Aug 30, 2024
* contracts: Add gas input to precompile pre-images (#186) Also update the cannon evm tests to use the new precompile preimage scheme. --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> * op-challenger: Support uploading data in new format. (#188) * op-program: Add required gas to precompile oracle key (#176) * op-challenger: Support multiple versions of the preimage oracle contract --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co> --------- Co-authored-by: inphi <mlaw2501@gmail.com> --------- Co-authored-by: Adrian Sutton <adrian@oplabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...with the FeeCurrency in celo/testing/FeeCurrency.sol . It also is a good idea to clearly name abstract contracts, so that nobody tries to use them as a non-abstract contract (e.g. tries a deployment).