Skip to content

fix(blob)!: update the blob.Proof to return a proof to the data root#3610

Merged
vgonkivs merged 52 commits intocelestiaorg:feature_branch_blob_prooffrom
rach-id:update-the-blob-proof
Aug 7, 2024
Merged

fix(blob)!: update the blob.Proof to return a proof to the data root#3610
vgonkivs merged 52 commits intocelestiaorg:feature_branch_blob_prooffrom
rach-id:update-the-blob-proof

Conversation

@rach-id
Copy link
Member

@rach-id rach-id commented Jul 31, 2024

Closes #3582

@rach-id rach-id self-assigned this Jul 31, 2024
@github-actions github-actions bot added the external Issues created by non node team members label Jul 31, 2024
@vgonkivs vgonkivs added the kind:misc Attached to miscellaneous PRs label Jul 31, 2024
@Wondertan Wondertan added kind:fix Attached to bug-fixing PRs and removed kind:misc Attached to miscellaneous PRs labels Jul 31, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment here otherwise thank u for tests :)

@vgonkivs
Copy link
Member

vgonkivs commented Aug 5, 2024

Btw, unit test failed

@rach-id
Copy link
Member Author

rach-id commented Aug 5, 2024

Unit test fixed: 712c272

was a good catch 👍

vgonkivs
vgonkivs previously approved these changes Aug 5, 2024
renaynay
renaynay previously approved these changes Aug 6, 2024
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rach-id let's get this over the line :)

@rach-id rach-id dismissed stale reviews from renaynay and vgonkivs via 26de33e August 6, 2024 10:48
@renaynay renaynay removed the v0.15.0 label Aug 6, 2024
@rach-id rach-id changed the base branch from main to feature_branch_blob_proof August 7, 2024 10:11
@vgonkivs vgonkivs merged commit 32d3137 into celestiaorg:feature_branch_blob_proof Aug 7, 2024
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Dec 9, 2024
…elestiaorg#3610)

Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external Issues created by non node team members kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge GetCommitmentProof with GetProof

6 participants