chore: clarify sort for blobs#888
Merged
rootulp merged 2 commits intocelestiaorg:v0.34.x-celestiafrom Nov 16, 2022
Merged
Conversation
6346d74 to
9e33838
Compare
rach-id
reviewed
Nov 16, 2022
Member
There was a problem hiding this comment.
Probably the tests also need to be renamed from message to blob.
example: https://github.com/rootulp/celestia-core/blob/9e33838f72574ee422f001053f64b777c4ff3893/types/block_test.go#L858.
Or should I create a separate issue for this?
Collaborator
Author
|
No need for separate issue, will keep #887 open until the rename is complete |
Member
|
why is the generated proto failing? that doesn't make any sense |
evan-forbes
requested changes
Nov 16, 2022
Member
|
I am having the same proto files fails on my branch. Apparently, the local version of |
rach-id
approved these changes
Nov 16, 2022
Collaborator
Author
|
Looks like a test flake |
evan-forbes
approved these changes
Nov 16, 2022
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
* Add Vote Extension varying size testnet (#888) This PR modifies the e2e app to allow varying the size of vote extensions to test the effect of VE on the system performance. Results of tests executed are also reported here. This work is being done as part of the v0.38.0 QA. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit 028fb5e) # Conflicts: # RELEASES.md * Fix conflict --------- Co-authored-by: Lasaro <lasaro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #887 by removing two exported methods which are no longer needed after this refactor: #879 (comment) and addressing this feedback: #879 (comment)
Testing
After this change, celestia-app can sort a slice of blobs via:
and verify a slice of blobs is sorted via: