update the nmt wrapper to the new rsmt2d.Tree interface#256
Merged
evan-forbes merged 8 commits intomasterfrom Mar 27, 2021
Merged
update the nmt wrapper to the new rsmt2d.Tree interface#256evan-forbes merged 8 commits intomasterfrom
evan-forbes merged 8 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 60.87% 62.07% +1.19%
==========================================
Files 261 260 -1
Lines 23640 23164 -476
==========================================
- Hits 14392 14380 -12
+ Misses 7759 7295 -464
Partials 1489 1489
|
evan-forbes
commented
Mar 27, 2021
Comment on lines
-203
to
-215
| var _ rsmt2d.Tree = &nmtWrapper{} | ||
|
|
||
| func newNmtConstructor() rsmt2d.Tree { | ||
| return &nmtWrapper{ | ||
| nmt.New(sha256.New()), | ||
| } | ||
| } | ||
|
|
||
| // we could get rid of this wrapper and use the nmt directly if we | ||
| // make Push take in the data as one one byte array (instead of two). | ||
| type nmtWrapper struct { | ||
| *nmt.NamespacedMerkleTree | ||
| } |
Member
Author
There was a problem hiding this comment.
This wrapper in the ipld plugin was not needed, because it was not used to generate roots.
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
…256) Partially addresses #158 (just for `main`). I'll submit per-release-branch backports manually. Since we're working in public now, this is all no longer necessary. --- #### PR checklist - [x] Tests written/updated, or no tests needed - [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed - [x] Updated relevant documentation (`docs/`) and code comments, or no documentation updates needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the nmt wrapper to the new rsmt2d.Tree interface.
I'm leaving as a draft as I think there are somethings that still need to be updated before this can be merged.good to go.Closes: #255