Conversation
a7467c7 to
9b4ee38
Compare
9b4ee38 to
1ef2500
Compare
|
I'd recommend to think about ways to split this up into multiple Pull Requests instead. At least two, maybe even three or more pull requests. Roughly this could look like the following approach:
The nice thing about this approach is that 1. and somewhat 2. as well are independent of #194, #85, and #182 etc. and can be reviewed and merged independently and faster. Only after 3. we will have parity with the Spec and can close #181. In between we would have data structures that kinda support both: vanilla tendermint and LazyLedger main chain logic. |
1ef2500 to
29f160d
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@Wondertan I'll close this PR but will leave the branch around. |
|
@liamsi, ok. I was thinking about closing it as well at some point, as it does things in the wrong way. |
Description(TODO)
Depends on:
https://github.com/lazyledger/nmt#22Closes: #181, closes #215, closes #85, closes #184
NOTE:
The PR is big and touches multiple issues at once, as I would like it to fully serve its goal in the name. Also, I'll do my best to make it easy to review via commit-by-commit reviewing, while preserving history.