Conversation
cmwaters
previously approved these changes
Jul 26, 2023
Collaborator
cmwaters
left a comment
There was a problem hiding this comment.
It would actually be more accurate to call the versions based off the abci version because what really matter is that our Frankenstein consensus engine fits with the SDK.
rootulp
commented
Jul 26, 2023
evan-forbes
previously approved these changes
Jul 27, 2023
evan-forbes
approved these changes
Jul 28, 2023
cmwaters
approved these changes
Jul 28, 2023
Collaborator
Author
|
Does celestia-core have the rule enabled that requires branches are up to date with main? I can't merge this yet... 
|
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
The PR closes issue #25 partially. Changes made: - Bump version v0.37 to v0.38 in docs. - Update docs to remove reference to `BeginBlock`, `EndBlock`, and `DeliverTx` and consolidate them into `FinalizeBlock.` - Minor changes to the formatting of docs. #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [X] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit d31be6b) Co-authored-by: Aliasgar Merchant <44069404+alijnmerchant21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is the expected workflow now but defer to @cmwaters