Revert "feat!: account for time already elapsed when waiting after the commit (#965)"#1033
Merged
evan-forbes merged 1 commit intov0.34.x-celestiafrom Jul 11, 2023
Merged
Conversation
cmwaters
approved these changes
Jul 11, 2023
rootulp
approved these changes
Jul 11, 2023
3 tasks
evan-forbes
pushed a commit
that referenced
this pull request
Mar 11, 2025
…different from the one returned in the preceding prepareProposal (#1033) (#1052) If a proposer fails after calling prepareProposal and before calling processProposal, then the following may happen upon restarting: - if failed before signing another message, then will invoke prepareProposal again, sign a new block, probably empty, and propose it; - if failed after signing a proposal but before writing the proposal message into the WAL, then will invoke prepareProposal and produce a new, probably empty block, [fail to sign it](https://github.com/cometbft/cometbft/blob/2789a59a9cc61c6ea56a6b266eeadf0f26ca2456/consensus/state.go#L1221), and not invoke processProposal; prevote timeouts will ensure the CometBFT is not stuck; - if failed after writing the proposal message to the WAL, then will invoke prepareProposal, produce a new, probably empty block, fail to sign it, and invoke processProposal with the block signed before crashing. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [x] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit b23ef56) Co-authored-by: Lasaro <lasaro@informal.systems>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit cc1bc3f.
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments