Flake8 fixes #9955
Merged
Flake8 fixes #9955
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses flake8 style issues by removing unnecessary nonlocal declarations in test code where variables are only read, not reassigned.
- Remove redundant nonlocal statements in nested function/method scopes
- No functional behavior changes; tests should behave identically
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| t/unit/tasks/test_stamping.py | Removed nonlocal declaration in on_signature; variable is only read, satisfying flake8 without changing behavior. |
| t/smoke/tests/test_thread_safe.py | Removed nonlocal declaration in signal handler; the variable is called, not reassigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9955 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 153 153
Lines 19299 19299
Branches 2211 2211
=======================================
Hits 15183 15183
Misses 3816 3816
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
kumuthu53
pushed a commit
to lynxx-apac/celery
that referenced
this pull request
Oct 22, 2025
* remove nonlocal to fix flake8 * remove nonlocal to fix flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.