Prepare for (pre) release: v5.6.0b2 #9938

Nusnus · 2025-10-11T15:03:07Z

Nusnus · 2025-10-11T16:46:29Z

FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_with_settings - AssertionError: assert {'maxPoolSize': 10, 'replicaSet': 'rs0'} == {'maxPoolSize': 10, 'replicaset': 'rs0'}
  
  Common items:
  {'maxPoolSize': 10}
  Left contains 1 more item:
  {'replicaSet': 'rs0'}
  Right contains 1 more item:
  {'replicaset': 'rs0'}
  
  Full diff:
    {
        'maxPoolSize': 10,
  -     'replicaset': 'rs0',
  ?             ^
  +     'replicaSet': 'rs0',
  ?             ^
    }
FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_init_mongodb_dnspython2_pymongo4_seedlist - AssertionError: assert {'maxPoolSize': 10, 'tls': True, 'replicaSet': 'rs0'} == {'maxPoolSize': 10, 'replicaset': 'rs0', 'tls': True}
  
  Common items:
  {'maxPoolSize': 10, 'tls': True}
  Left contains 1 more item:
  {'replicaSet': 'rs0'}
  Right contains 1 more item:
  {'replicaset': 'rs0'}
  
  Full diff:
    {
        'maxPoolSize': 10,
  -     'replicaset': 'rs0',
  ?             ^
  +     'replicaSet': 'rs0',
  ?             ^
        'tls': True,
    }
FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_get_connection_with_authmechanism - AssertionError: expected call not found.
Expected: MongoClient(host=['localhost:27017'], username='celeryuser', password='celerypassword', authmechanism='SCRAM-SHA-256', maxPoolSize=10)
  Actual: MongoClient(maxPoolSize=10, authMechanism='SCRAM-SHA-256', host=['localhost:27017'], username='celeryuser', password='celerypassword')
FAILED t/unit/backends/test_mongodb.py::test_MongoBackend::test_get_connection_with_authmechanism_no_username - AssertionError: expected call not found.
Expected: MongoClient(host=['localhost:27017'], authmechanism='SCRAM-SHA-256', maxPoolSize=10)
  Actual: MongoClient(maxPoolSize=10, authMechanism='SCRAM-SHA-256', host=['localhost:27017'])
========================================================== 4 failed, 3506 passed, 10 skipped, 3 xfailed, 61 warnings, 28958 subtests passed in 291.98s (0:04:51) ===========================================================
3.13-unit: exit 1 (305.72 seconds) /Users/nusnus/dev/GitHub/celery> pytest -vv --maxfail=10 --capture=no -v --cov=celery --cov-report=xml --junitxml=junit.xml -o junit_family=legacy --cov-report term pid=84291
  3.13-unit: FAIL code 1 (309.76=setup[4.04]+cmd[305.72] seconds)
  evaluation failed :( (327.85 seconds)

auvipy · 2025-10-12T05:05:07Z

here is a possible relevant comment celery/kombu#2376 (comment)

auvipy · 2025-10-12T05:06:09Z

for now this might help celery/kombu#2384

auvipy

now the CI is passing with kombu changes

codecov · 2025-10-12T07:20:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.67%. Comparing base (c4e4bab) to head (3c7f973).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9938      +/-   ##
==========================================
- Coverage   78.67%   78.67%   -0.01%     
==========================================
  Files         153      153              
  Lines       19299    19299              
  Branches     2211     2211              
==========================================
- Hits        15184    15183       -1     
  Misses       3816     3816              
- Partials      299      300       +1

Flag	Coverage Δ
unittests	`78.65% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Nusnus · 2025-10-12T09:12:10Z

now the CI is passing with kombu changes

👑

I'll continue now, thank you!

auvipy · 2025-10-12T15:50:36Z

you can go for it

Nusnus · 2025-10-13T04:26:39Z

you can go for it

Docker build is failing in CI

auvipy · 2025-10-13T07:39:57Z

yes, you can check it locally and then go for it after fixing!

Nusnus · 2025-10-14T06:29:01Z

yes, you can check it locally and then go for it after fixing!

It needs to pass in the CI 🙏

Nusnus · 2025-10-14T06:34:55Z

I’ve just rebased on main and I’m getting lint errors:

pyupgrade................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

t/smoke/tests/test_thread_safe.py:59:13: F824 `nonlocal signal_was_called` is unused: name is never assigned in scope
t/unit/tasks/test_stamping.py:666:17: F824 `nonlocal expected_sig` is unused: name is never assigned in scope

@auvipy please don’t merge any PR if it’s not 100% green on the CI. It makes it really hard to backtrack what broke the CI and I’ve wasted days over such cases in the last recent months.

auvipy · 2025-10-18T19:44:10Z

new versions of flake8 find out some issues. they are fixed in main branch now. CI should be green here after a while.

Nusnus · 2025-10-18T19:45:12Z

@auvipy

new versions of flake8 find out some issues. they are fixed in main branch now. CI should be green here after a while.

Awesome! Thank you for taking care of this! 🔥

I’ll continue with the release in a couple of hours!

Nusnus · 2025-10-18T21:06:31Z

Found an issue with the reqs:

Downloading future-1.0.0-py3-none-any.whl (491 kB)
Downloading pytz-2025.2-py2.py3-none-any.whl (509 kB)
Building wheels for collected packages: kombu, pylibmc, cassandra-driver, softlayer_messaging, pyArango
  Building wheel for kombu (pyproject.toml) ... done
  Created wheel for kombu: filename=kombu-5.6.0rc1-py3-none-any.whl size=213837 sha256=cac7f807c8338658d5b23fb333c6b5533eebc3cd6f43adb98b76efe8dc93c0fd
  Stored in directory: /private/var/folders/0s/45pg54ln0mxfn7lrxb5bqp100000gn/T/pip-ephem-wheel-cache-nypu8ooj/wheels/42/51/29/2c602c8e035c7550fee8b565b1b35a60a1ded4a7f49fbe8b61
  DEPRECATION: Building 'pylibmc' using the legacy setup.py bdist_wheel mechanism, which will be removed in a future version. pip 25.3 will enforce this behaviour change. A possible replacement is to use the standardized build interface by setting the `--use-pep517` option, (possibly combined with `--no-build-isolation`), or adding a `pyproject.toml` file to the source tree of 'pylibmc'. Discussion can be found at https://github.com/pypa/pip/issues/6334
  Building wheel for pylibmc (setup.py) ... done
  Created wheel for pylibmc: filename=pylibmc-1.6.3-cp313-cp313-macosx_15_0_arm64.whl size=33689 sha256=75aeac66acb1557cfab324c0a9604b57fd7449fb36ee22fa04bffabedca3b5a7
  Stored in directory: /Users/nusnus/Library/Caches/pip/wheels/fc/a2/e5/fef27700c9a6a9f65299199c2a9ef73df71517981608d4ba77
  DEPRECATION: Building 'cassandra-driver' using the legacy setup.py bdist_wheel mechanism, which will be removed in a future version. pip 25.3 will enforce this behaviour change. A possible replacement is to use the standardized build interface by setting the `--use-pep517` option, (possibly combined with `--no-build-isolation`), or adding a `pyproject.toml` file to the source tree of 'cassandra-driver'. Discussion can be found at https://github.com/pypa/pip/issues/6334
  Building wheel for cassandra-driver (setup.py) ... done
  Created wheel for cassandra-driver: filename=cassandra_driver-3.29.2-cp313-cp313-macosx_15_0_arm64.whl size=335909 sha256=6273d1d238dde3a3873601b890d7f75cd9ce3fd623e08e76ffb7c3c1a412ed65
  Stored in directory: /Users/nusnus/Library/Caches/pip/wheels/ab/e6/16/a8ddddf3d6c34eaa48769f4bc80ea75ad46afcad10e5b4634d
  DEPRECATION: Building 'softlayer_messaging' using the legacy setup.py bdist_wheel mechanism, which will be removed in a future version. pip 25.3 will enforce this behaviour change. A possible replacement is to use the standardized build interface by setting the `--use-pep517` option, (possibly combined with `--no-build-isolation`), or adding a `pyproject.toml` file to the source tree of 'softlayer_messaging'. Discussion can be found at https://github.com/pypa/pip/issues/6334
  Building wheel for softlayer_messaging (setup.py) ... done
  Created wheel for softlayer_messaging: filename=softlayer_messaging-1.0.3-py3-none-any.whl size=7745 sha256=c77527e3e07f81b3e7adb43376664b3ca7be03e2ff1722b01d760593cf92da45
  Stored in directory: /Users/nusnus/Library/Caches/pip/wheels/7c/1b/3b/626c64f7d895c01d44ea65ab904389121b783f2101ed08c607
  DEPRECATION: Building 'pyArango' using the legacy setup.py bdist_wheel mechanism, which will be removed in a future version. pip 25.3 will enforce this behaviour change. A possible replacement is to use the standardized build interface by setting the `--use-pep517` option, (possibly combined with `--no-build-isolation`), or adding a `pyproject.toml` file to the source tree of 'pyArango'. Discussion can be found at https://github.com/pypa/pip/issues/6334
  Building wheel for pyArango (setup.py) ... done
  Created wheel for pyArango: filename=pyarango-2.1.1-py2.py3-none-any.whl size=53329 sha256=4256cd96344456c71002a000c0ff432ad2b0e31bc09b8c0bd5d15e5f16d611a5
  Stored in directory: /Users/nusnus/Library/Caches/pip/wheels/9b/1b/6f/b296e4e99ff6c528f4f84c49c57c06a8898b91f2bf1f9bb931
Successfully built kombu pylibmc cassandra-driver softlayer_messaging pyArango
Installing collected packages: pytz, ephem, tblib, sqlalchemy, pylibmc, pycurl, msgpack, geomet, future, elastic-transport, datetime, coverage, softlayer_messaging, python-consul2, pytest-github-actions-annotate-failures, pydocumentdb, pycouchdb, pyArango, kombu, elasticsearch, cassandra-driver, pytest-cov
  Attempting uninstall: msgpack
    Found existing installation: msgpack 1.1.0
    Uninstalling msgpack-1.1.0:
      Successfully uninstalled msgpack-1.1.0
  Attempting uninstall: kombu
    Found existing installation: kombu 5.5.4
    Uninstalling kombu-5.5.4:
      Successfully uninstalled kombu-5.5.4
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
celery 5.5.3 requires kombu<5.6,>=5.5.2, but you have kombu 5.6.0rc1 which is incompatible.

From kombu’s pip install:

Requirement already satisfied: boto3>=1.26.143 in /Users/nusnus/.pyenv/versions/3.13.0/lib/python3.13/site-packages (from -r requirements/funtest.txt (line 11)) (1.40.55)
Collecting qpid-python>=0.26 (from -r requirements/funtest.txt (line 14))
  Using cached qpid-python-1.36.0-1.tar.gz (224 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [16 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
          exec(compile('''
          ~~~~^^^^^^^^^^^^
          # This is <pip-setuptools-caller> -- a caller that pip uses to run setup.py
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ...<32 lines>...
          exec(compile(setup_py_code, filename, "exec"))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
          ''' % ('/private/var/folders/0s/45pg54ln0mxfn7lrxb5bqp100000gn/T/pip-install-jdfq60k3/qpid-python_35466e64651041cc86e76a2054e64fad/setup.py',), "<pip-setuptools-caller>", "exec"))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "<pip-setuptools-caller>", line 35, in <module>
        File "/private/var/folders/0s/45pg54ln0mxfn7lrxb5bqp100000gn/T/pip-install-jdfq60k3/qpid-python_35466e64651041cc86e76a2054e64fad/setup.py", line 42
          raise DistutilsFileError, \
                                  ^
      SyntaxError: invalid syntax
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
Ignoring backports.zoneinfo: markers 'python_version < "3.9"' don't match your environment
Requirement already satisfied: amqp<6.0.0,>=5.1.1 in /Users/nusnus/.pyenv/versions/3.13.0/lib/python3.13/site-packages (from -r requirements/default.txt (line 1)) (5.3.1)

auvipy · 2025-10-19T05:00:34Z

the qpid dependency upgrade is a long overdue. we can ignore that for this release. but I will also check what can be done there

auvipy · 2025-10-19T05:07:20Z

this pr celery/kombu#2391 should remove one warning.

auvipy · 2025-10-19T07:04:55Z

CI is green here. may be we should release rc2 of kombu and see?

…5.6.0rc2 (minimum version)

Nusnus · 2025-10-20T08:18:40Z

CI is green here. may be we should release rc2 of kombu and see?

💯

Kombu v5.6.0rc2 Released: https://github.com/celery/kombu/releases/tag/v5.6.0rc2
This PR was updated (recent changes -> changelog + kombu bump).

Everything passes locally for me (full CI locally, both kombu and celery), so I’ll release Celery v5.6.0b2 the moment the CI finishes :)

* Bump version: 5.6.0b1 → 5.6.0b2 * Added Changelog for v5.6.0b2 * Remove Python 3.8 support from the release docs and update Kombu to v5.6.0rc2 (minimum version)

mongodb/mongo-python-driver#2413 caused some test regressions here. This isn't currently a problem for the upstream test suite since it pins pymongo==4.10.1 via kombu, but we're running into it in Debian where we've already upgraded pymongo for other reasons. kombu already tried to upgrade pymongo but had to revert due to these test regressions (see celery/kombu#2384 and celery#9938). One of the test fixes (relating to `mongodb_backend_settings`) illustrates an incompatibility where I couldn't figure out a reasonable way to avoid passing it through to Celery users, so I added a note to the documentation about it. It may also be worth including a brief mention of it in the release notes. Using the canonical case for the option in question should work with both old and new versions of pymongo.

mongodb/mongo-python-driver#2413 caused some test regressions here. This isn't currently a problem for the upstream test suite since it pins pymongo==4.10.1 via kombu, but we're running into it in Debian where we've already upgraded pymongo for other reasons. kombu already tried to upgrade pymongo but had to revert due to these test regressions (see celery/kombu#2384 and #9938). One of the test fixes (relating to `mongodb_backend_settings`) illustrates an incompatibility where I couldn't figure out a reasonable way to avoid passing it through to Celery users, so I added a note to the documentation about it. It may also be worth including a brief mention of it in the release notes. Using the canonical case for the option in question should work with both old and new versions of pymongo. Co-authored-by: Asif Saif Uddin {"Auvi":"অভি"} <auvipy@gmail.com>

Nusnus self-assigned this Oct 11, 2025

auvipy closed this Oct 12, 2025

auvipy reopened this Oct 12, 2025

auvipy approved these changes Oct 12, 2025

View reviewed changes

auvipy marked this pull request as ready for review October 12, 2025 07:15

Nusnus force-pushed the release branch from 0daa0ad to bcbe758 Compare October 12, 2025 14:30

Nusnus force-pushed the release branch from bcbe758 to fd5689d Compare October 14, 2025 06:29

Nusnus force-pushed the release branch from fd5689d to fb7ddb1 Compare October 14, 2025 06:36

auvipy added this to the 5.6.0 milestone Oct 18, 2025

auvipy approved these changes Oct 18, 2025

View reviewed changes

Nusnus force-pushed the release branch from e2bf0c6 to 3f03d34 Compare October 19, 2025 11:06

Nusnus added 3 commits October 20, 2025 11:07

Bump version: 5.6.0b1 → 5.6.0b2

09c87a2

Added Changelog for v5.6.0b2

ad57375

Remove Python 3.8 support from the release docs and update Kombu to v…

3c7f973

…5.6.0rc2 (minimum version)

Nusnus force-pushed the release branch from 3f03d34 to 3c7f973 Compare October 20, 2025 08:16

Nusnus merged commit 2731860 into celery:main Oct 20, 2025
106 checks passed

Nusnus deleted the release branch October 20, 2025 08:44

cjwatson mentioned this pull request Oct 27, 2025

Make tests compatible with pymongo >= 4.14 #9968

Merged

Uh oh!

Prepare for (pre) release: v5.6.0b2 #9938

Prepare for (pre) release: v5.6.0b2 #9938

Uh oh!

Conversation

Nusnus commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nusnus commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auvipy commented Oct 12, 2025

Uh oh!

auvipy commented Oct 12, 2025

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Nusnus commented Oct 12, 2025

Uh oh!

auvipy commented Oct 12, 2025

Uh oh!

Nusnus commented Oct 13, 2025

Uh oh!

auvipy commented Oct 13, 2025

Uh oh!

Nusnus commented Oct 14, 2025

Uh oh!

Nusnus commented Oct 14, 2025

Uh oh!

auvipy commented Oct 18, 2025

Uh oh!

Nusnus commented Oct 18, 2025

Uh oh!

Nusnus commented Oct 18, 2025

Uh oh!

auvipy commented Oct 19, 2025

Uh oh!

auvipy commented Oct 19, 2025

Uh oh!

auvipy commented Oct 19, 2025

Uh oh!

Nusnus commented Oct 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Nusnus commented Oct 11, 2025 •

edited

Loading

Nusnus commented Oct 11, 2025 •

edited

Loading

codecov bot commented Oct 12, 2025 •

edited

Loading