Skip to content

Remove dependency on pycurl #9526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nusnus merged 4 commits into from
Feb 21, 2025
Merged

Remove dependency on pycurl #9526

Nusnus merged 4 commits into from
Feb 21, 2025

Conversation

@jmsmkn
Copy link
Contributor

@jmsmkn jmsmkn commented Jan 28, 2025

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

The dependency on pycurl was removed from kombu[sqs] in celery/kombu#2134, so is no longer required here.

See #3619

@jmsmkn jmsmkn mentioned this pull request Jan 28, 2025
Closed
@Nusnus Nusnus self-requested a review January 28, 2025 17:39
@codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (b7abaac) to head (c7e1582).
Report is 54 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9526   +/-   ##
=======================================
  Coverage   78.24%   78.24%           
=======================================
  Files         153      153           
  Lines       19050    19050           
  Branches     2520     2520           
=======================================
  Hits        14905    14905           
  Misses       3859     3859           
  Partials      286      286
Flag Coverage Δ
unittests 78.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

auvipy
auvipy requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you find any remnant of pycurl in celery please?

@jmsmkn
Copy link
Contributor Author

jmsmkn commented Jan 29, 2025

There was an additional one in the tests, thanks for pointing that out! Now there are only references to it in the release notes: https://github.com/search?q=repo%3Acelery%2Fcelery%20pycurl&type=code

jmsmkn added 2 commits January 29, 2025 15:39
@jmsmkn @Nusnus
Remove dependency on pycurl
3026d5f 
The dependency on `pycurl` was removed from `kombu[sqs]` in celery/kombu#2134, so is no longer required here. See celery#3619
@jmsmkn @Nusnus
Update test-ci-default.txt
f392d43
@jmsmkn
Copy link
Contributor Author

jmsmkn commented Jan 29, 2025

It looks like CI is still failing as it is requiring pycurl from pytest-celery[all]. This is a requirement in pytest-celery=1.1.3 but has since been removed. However, that change is currently unreleased.

@auvipy
Copy link
Member

auvipy commented Feb 2, 2025

yeah we might need to wait for a new release of pytest-celery

@jmsmkn jmsmkn mentioned this pull request Feb 20, 2025
Closed
4 tasks
@Nusnus
Copy link
Member

Nusnus commented Feb 21, 2025

Done: #9568

Nusnus
Nusnus approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nusnus Nusnus merged commit 9bf0546 into celery:main Feb 21, 2025
70 checks passed
@jmsmkn jmsmkn deleted the patch-1 branch February 22, 2025 08:23
@auvipy auvipy added this to the 5.5.0 milestone Feb 24, 2025
@Nusnus Nusnus mentioned this pull request Mar 15, 2025
Closed
auvipy added a commit that referenced this pull request Mar 15, 2025
@auvipy
Revert "Remove dependency on pycurl (#9526)"
a98164a 
This reverts commit 9bf0546.
@auvipy auvipy mentioned this pull request Mar 15, 2025
Merged
auvipy added a commit that referenced this pull request Jul 10, 2025
@auvipy
Revert "Remove dependency on pycurl (#9526)" (#9620)
bf1c98b 
This reverts commit 9bf0546.
auvipy added a commit that referenced this pull request Jul 28, 2025
@auvipy
Revert "Revert "Remove dependency on pycurl (#9526)" (#9620)"
6f759cf 
This reverts commit bf1c98b.
Nusnus added a commit to Nusnus/celery that referenced this pull request Aug 13, 2025
@Nusnus
Reapply "Remove dependency on pycurl (celery#9526)" (celery#9620)
e936c0f 
This reverts commit bf1c98b.
Nusnus added a commit to Nusnus/celery that referenced this pull request Aug 13, 2025
@Nusnus
Reapply "Remove dependency on pycurl (celery#9526)" (celery#9620)
02f20eb 
This reverts commit bf1c98b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nusnus Nusnus Nusnus approved these changes

@auvipy auvipy auvipy approved these changes

Assignees

No one assigned

Labels

PR Type: Cleanup

Projects

None yet

Milestone

5.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jmsmkn @auvipy @Nusnus