Fix recursive result parents on group in middle of chain#8903
Fix recursive result parents on group in middle of chain#8903Nusnus merged 2 commits intocelery:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8903 +/- ##
==========================================
+ Coverage 81.47% 81.48% +0.01%
==========================================
Files 150 150
Lines 18681 18686 +5
Branches 3192 3193 +1
==========================================
+ Hits 15221 15227 +6
Misses 3168 3168
+ Partials 292 291 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
left a comment
There was a problem hiding this comment.
thanks for the proposed fix with unit test. should we try to add extra integration tests for this as well? it's not mandatory though
You were reading my mind @auvipy . But let's see first if the CI passed successfully with the current tests. |
Nusnus
left a comment
There was a problem hiding this comment.
Regardless, the fix does look good
|
@Nusnus I've added the integration test, but now one of the checks is not successful, I don't think it has anything to do with me, it's getting connection refused from the Redis. |
Indeed, unrelated. Merged! Good work, thank you. |
Description
This fixes issue #8890
Which is a bug when trying to freeze a chain that contains a group and more than 2 tasks after it
Also added a test case