Fix DeprecationWarning: datetime.datetime.utcnow()#8726
Merged
auvipy merged 2 commits intocelery:mainfrom Dec 19, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8726 +/- ##
==========================================
- Coverage 87.27% 87.24% -0.04%
==========================================
Files 148 148
Lines 18636 18637 +1
Branches 3199 3199
==========================================
- Hits 16265 16260 -5
- Misses 2078 2080 +2
- Partials 293 297 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
requested changes
Dec 14, 2023
Member
auvipy
left a comment
There was a problem hiding this comment.
you can make it draft before the builds are passing
> lib/python3.12/site-packages/celery/app/base.py:940: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC).
now_in_utc = to_utc(datetime.utcnow())
auvipy
reviewed
Dec 14, 2023
Member
|
Restarting CI, unrelated error |
auvipy
approved these changes
Dec 19, 2023
Member
|
great job! thanks a lot |
Contributor
Author
|
There is more |
cclauss
added a commit
to cclauss/celery
that referenced
this pull request
Dec 19, 2023
A continuation of celery#8726 * celery#8726 % `python3.12` ``` >>> from datetime import datetime, timezone >>> datetime.now(timezone.utc).isoformat()[:-9], datetime.utcnow().isoformat()[:-3] <stdin>:1: DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.now(datetime.UTC). ('2023-12-19T21:15:19.935', '2023-12-19T21:15:19.935')
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix DeprecationWarning: datetime.datetime.utcnow() on Python 3.12
https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow