Skip to content

Add type annotation on concurrency/solo.py#7823

Closed
Kludex wants to merge 3 commits intocelery:mainfrom
Kludex:typing/concurrency/solo
Closed

Add type annotation on concurrency/solo.py#7823
Kludex wants to merge 3 commits intocelery:mainfrom
Kludex:typing/concurrency/solo

Conversation

@Kludex
Copy link
Copy Markdown
Contributor

@Kludex Kludex commented Oct 17, 2022 •
edited
Loading

@Kludex Kludex mentioned this pull request Oct 17, 2022
Open
Kludex
Kludex commented Oct 17, 2022
View reviewed changes
Kludex
Kludex commented Oct 17, 2022
View reviewed changes
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2022 •
edited
Loading

Codecov Report

Base: 86.98% // Head: 89.30% // Increases project coverage by +2.31% 🎉

Coverage data is based on head (f8af54a) compared to base (fcd8fdd).
Patch coverage: 66.66% of modified lines in pull request are covered.

❗ Current head f8af54a differs from pull request most recent head 92d32f4. Consider uploading reports for the commit 92d32f4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7823      +/-   ##
==========================================
+ Coverage   86.98%   89.30%   +2.31%     
==========================================
  Files         148      128      -20     
  Lines       18468    15932    -2536     
  Branches     2516     2120     -396     
==========================================
- Hits        16065    14228    -1837     
+ Misses       2123     1473     -650     
+ Partials      280      231      -49
Flag Coverage Δ
unittests 89.28% <66.66%> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/concurrency/solo.py 84.21% <66.66%> (-15.79%) ⬇️
celery/concurrency/thread.py 75.75% <0.00%> (-20.68%) ⬇️
celery/schedules.py 84.14% <0.00%> (-13.39%) ⬇️
celery/utils/threads.py 93.64% <0.00%> (-6.36%) ⬇️
celery/bin/shell.py 28.16% <0.00%> (-5.73%) ⬇️
celery/backends/s3.py 90.38% <0.00%> (-5.54%) ⬇️
celery/fixups/django.py 88.57% <0.00%> (-5.33%) ⬇️
celery/utils/log.py 86.18% <0.00%> (-3.55%) ⬇️
celery/backends/database/session.py 95.00% <0.00%> (-3.28%) ⬇️
celery/backends/consul.py 83.05% <0.00%> (-2.92%) ⬇️
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Omer Katz and others added 2 commits January 29, 2023 14:32
@Kludex
Apply suggestions from code review
9dc6ade 
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@Kludex
Merge branch 'main' into typing/concurrency/solo
92d32f4
@auvipy
Copy link
Copy Markdown
Member

auvipy commented Jan 30, 2023

I am not sure why the CI is failing

@Nusnus
Copy link
Copy Markdown
Member

Nusnus commented Jan 30, 2023 •
edited
Loading

I am not sure why the CI is failing

This error:

AttributeError: type object 'SQLiteDialect_pysqlite' has no attribute 'dbapi'

It is fixed by the merged PR: #8033

This PR needs to be rebased on main @Kludex

@Kludex Kludex closed this by deleting the head repository Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kludex @auvipy @Nusnus