Revert "sqlalchemy==1.4.46 (#7995)"#8033
Merged
Nusnus merged 1 commit intocelery:mainfrom Jan 29, 2023
Merged
Conversation
This reverts commit e54780f.
Codecov ReportBase: 86.98% // Head: 86.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8033 +/- ##
=======================================
Coverage 86.98% 86.98%
=======================================
Files 148 148
Lines 18468 18468
Branches 2516 2516
=======================================
Hits 16065 16065
Misses 2123 2123
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change
sqlalchemy==1.4.46broke the unit tests inmainso I'm reverting it until we find a better fix because we can't have main broken.I'm merging this PR now as we cannot have
mainbroken.This is an issue for me because I found a bug in the
Task.replaceand I have a fix that I can't merge because it fails for issues caused from the reverted commit.FYI @auvipy