Add args to LOG_RECEIVED (fixes #6885)#6898
Add args to LOG_RECEIVED (fixes #6885)#6898thedrow merged 2 commits intocelery:masterfrom daveisfera:master
Conversation
|
This pull request fixes 2 alerts when merging 359bb27 into ebeb4a4 - view on LGTM.com fixed alerts:
|
auvipy
left a comment
There was a problem hiding this comment.
please check the test failures
|
Are there instructions on how to run the tests locally? |
|
Sorry for the delay. I still haven't fixed my local setup to work with the GitHub password changes, so I couldn't push changes and just ended up doing it through the web UI, so hopefully the tests will pass now. |
Codecov Report
@@ Coverage Diff @@
## master #6898 +/- ##
==========================================
- Coverage 89.23% 89.20% -0.03%
==========================================
Files 138 138
Lines 16626 16654 +28
Branches 2099 2106 +7
==========================================
+ Hits 14836 14857 +21
- Misses 1571 1577 +6
- Partials 219 220 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request fixes 2 alerts when merging 574e0ca into 2ac3310 - view on LGTM.com fixed alerts:
|
* Add args and kwargs to LOG_RECEIVED and LOG_SUCCESS * Add kwargs and args to test
|
hey @daveisfera is there a way to get rid of args n kwargs from getting logged ? |
|
Should be possible by customizing the logger config. I haven't done that myself (because I wanted the |
|
@daveisfera @thedrow @auvipy (and all) - apologies if this is the wrong place to post this. In celery 4.x the "received" logs will show the task's ETA if available. Example: |
we got a new PR here #8301 please check |
Description
Add
argsto thecontextthat's logged withLOG_RECEIVED(likeLOG_REJECTED)Fixed #6885