create github action for windows by graingert · Pull Request #6271 · celery/celery

graingert · 2020-08-01T16:18:53Z

an action to potentially replace appveyor, which seems a bit unreliable on cloning

Note: Before submitting this pull request, please review our contributing
guidelines.

Description

graingert · 2020-08-01T16:20:25Z

@auvipy sadly I think it needs merging into the default branch before it will run the actions on PRs

graingert · 2020-08-01T16:26:36Z

ah you can see the windows status here: https://github.com/graingert/celery/pull/1/checks?check_run_id=935657081

auvipy · 2020-08-01T16:39:56Z

this is better than appveyor

graingert · 2020-08-01T17:40:15Z

this is better than appveyor

Yeah, I think so

graingert · 2020-08-01T17:40:53Z

@auvipy I can remove appveyor in a follow-up

graingert · 2020-08-01T17:42:32Z

.github/workflows/windows.yml

+      - name: Build
+        run: python setup.py bdist_wheel
+
+      - uses: actions/upload-artifact@v2


@auvipy do we need this step? celery ships universal wheels so it seems redundant

seems redundant

codecov · 2020-08-01T17:48:36Z

Codecov Report

Merging #6271 (c1fb8eb) into master (59d8832) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6271   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files         138      138           
  Lines       16616    16616           
  Branches     2098     2098           
=======================================
  Hits        13165    13165           
  Misses       3227     3227           
  Partials      224      224

Flag	Coverage Δ
unittests	`79.23% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
celery/backends/asynchronous.py	`60.64% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d8832...c1fb8eb. Read the comment docs.

graingert · 2020-08-02T10:38:15Z

@auvipy also you get 4020 concurrent builds on decent hardware, rather than 4 potatoes

graingert · 2020-08-02T11:27:17Z

@thedrow it feels like Github Actions is the spiritual successor to azure pipelines: https://docs.github.com/en/actions/migrating-to-github-actions/migrating-from-azure-pipelines-to-github-actions

graingert · 2020-08-02T11:50:07Z

but to make this permanent in all of our repositories we need a CEP.

I've only made this a Windows job to celery/celery because only the AppVeyor celery/celery job is impacting me directly - I do think it's worth switching wholesale but I think this PR is a step forward either way.

auvipy

should we try this as test purpose?

.github/workflows/windows.yml

auvipy · 2020-11-10T13:41:03Z

.github/workflows/windows.yml

+      - name: Build
+        run: python setup.py bdist_wheel
+
+      - uses: actions/upload-artifact@v2


seems redundant

…action-for-windows

.github/workflows/windows.yml

graingert · 2021-07-21T10:41:11Z

@graingert Would you mind setting it up so that if a wheel is not present in CI, it will still build the extension?

looks like a huge pain to do. I think removing pycurl and using a modern async client (httpx) is the only way here

…n32, py38+

lgtm-com · 2021-07-21T12:18:46Z

This pull request introduces 2 alerts and fixes 3 when merging bf8c2ff into c557c75 - view on LGTM.com

new alerts:

1 for Non-exception in 'except' clause
1 for Module is imported with 'import' and 'import from'

fixed alerts:

2 for Missing call to `__init__` during object initialization
1 for Unused import

graingert · 2021-07-21T12:19:40Z

I'll xfail all these remaining failures and rebase away my mistakes shortly

pytest-dev/pytest#8928

this is because Microsft is beyond reproach

lgtm-com · 2021-07-21T14:22:30Z

This pull request introduces 2 alerts and fixes 3 when merging 8b37458 into c557c75 - view on LGTM.com

new alerts:

1 for Non-exception in 'except' clause
1 for Module is imported with 'import' and 'import from'

fixed alerts:

2 for Missing call to `__init__` during object initialization
1 for Unused import

graingert · 2021-07-21T16:03:49Z

@auvipy I made an attempt to work around pycurl here and support py3.9, but it drifted too much from the original scope/goal of this PR.

This PR is actually ready for review and I don't plan to touch it again unless you request changes.

I'm continuing the py3.9+ work here: #6868

.github/workflows/python-package.yml

lgtm-com · 2021-07-22T09:01:44Z

This pull request introduces 2 alerts when merging c1fb8eb into 59d8832 - view on LGTM.com

new alerts:

2 for Wrong name for an argument in a call

* create github action for windows * increase tox verbosity * configure pip caching/requirements * Update .github/workflows/windows.yml * define kombu sqs passthrough dep * drop 3.9 from windows due to pycurl * skip test_check_privileges_suspicious_platform[accept_content0] on win32, py38+ * fails on py38+ win32 * bump the maxfail a bit to get more error context * xfail all py3.8+ windows tests * re-enable -v * pytest.raises does not raise AssertionError pytest-dev/pytest#8928 * more xfails * merge windows workflow into python-package * only install apt packages on ubuntu-* * bust pip cache with matrix.os * step.if doesn't need {{ * Update python-package.yml * Windows is never considerred a sus platform this is because Microsft is beyond reproach * fix merge resolution error

graingert force-pushed the create-github-action-for-windows branch from 4a3c620 to eaee165 Compare August 1, 2020 16:23

graingert force-pushed the create-github-action-for-windows branch 2 times, most recently from 4454dbb to 94148d7 Compare August 1, 2020 17:15

graingert commented Aug 1, 2020

View reviewed changes

graingert force-pushed the create-github-action-for-windows branch from 94148d7 to b774139 Compare August 1, 2020 17:59

graingert added 3 commits August 2, 2020 11:35

create github action for windows

322e00e

increase tox verbosity

6db466d

configure pip caching/requirements

81d3184

graingert force-pushed the create-github-action-for-windows branch from b774139 to 81d3184 Compare August 2, 2020 10:35

auvipy previously requested changes Nov 10, 2020

View reviewed changes

auvipy self-assigned this Feb 6, 2021

auvipy added this to the 5.2 milestone Feb 6, 2021

graingert added 2 commits July 21, 2021 08:20

Merge branch 'master' of github.com:celery/celery into create-github-…

5a41fa9

…action-for-windows

Update .github/workflows/windows.yml

9cb0f78

graingert closed this Jul 21, 2021

graingert reopened this Jul 21, 2021

define kombu sqs passthrough dep

1a4c3e9

graingert commented Jul 21, 2021

View reviewed changes

.github/workflows/windows.yml Outdated Show resolved Hide resolved

drop 3.9 from windows due to pycurl

7aa5a71

skip test_check_privileges_suspicious_platform[accept_content0] on wi…

78f7026

…n32, py38+

graingert added 4 commits July 21, 2021 12:07

fails on py38+ win32

d97d549

bump the maxfail a bit to get more error context

b1612d9

xfail all py3.8+ windows tests

3edaca8

re-enable -v

bf8c2ff

graingert requested a review from auvipy July 21, 2021 12:19

graingert added 8 commits July 21, 2021 13:59

pytest.raises does not raise AssertionError

71e2b0c

pytest-dev/pytest#8928

more xfails

16da70e

merge windows workflow into python-package

c956a90

only install apt packages on ubuntu-*

c8a034f

bust pip cache with matrix.os

114969a

step.if doesn't need {{

1caf6f0

Update python-package.yml

ed63c3f

Windows is never considerred a sus platform

8b37458

this is because Microsft is beyond reproach

graingert force-pushed the create-github-action-for-windows branch from e99e39c to 8b37458 Compare July 21, 2021 16:00

Merge branch 'master' into create-github-action-for-windows

b38ae8d

graingert commented Jul 22, 2021

View reviewed changes

.github/workflows/python-package.yml Outdated Show resolved Hide resolved

fix merge resolution error

c1fb8eb

thedrow merged commit bb80305 into celery:master Jul 22, 2021

graingert deleted the create-github-action-for-windows branch July 22, 2021 09:30

hannseman mentioned this pull request Nov 10, 2021

Installation by a requirements.txt generated by pip-tools fails #7070

Closed

18 tasks

Uh oh!

Conversation

graingert commented Aug 1, 2020

Description

Uh oh!

graingert commented Aug 1, 2020

Uh oh!

graingert commented Aug 1, 2020

Uh oh!

auvipy commented Aug 1, 2020

Uh oh!

graingert commented Aug 1, 2020

Uh oh!

graingert commented Aug 1, 2020

Uh oh!

graingert Aug 1, 2020

Choose a reason for hiding this comment

Uh oh!

auvipy Nov 10, 2020

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graingert commented Aug 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graingert commented Aug 2, 2020

Uh oh!

graingert commented Aug 2, 2020

Uh oh!

auvipy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auvipy Nov 10, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

graingert commented Jul 21, 2021

Uh oh!

lgtm-com bot commented Jul 21, 2021

Uh oh!

graingert commented Jul 21, 2021

Uh oh!

lgtm-com bot commented Jul 21, 2021

Uh oh!

graingert commented Jul 21, 2021

Uh oh!

Uh oh!

lgtm-com bot commented Jul 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Aug 1, 2020 •

edited

Loading

graingert commented Aug 2, 2020 •

edited

Loading