Skip to content

changed x-ha-policy to ha-mode for rabbitmq 3 changes#4971

Merged
auvipy merged 1 commit intocelery:masterfrom
auvipy:hapol
Aug 13, 2018
Merged

changed x-ha-policy to ha-mode for rabbitmq 3 changes#4971
auvipy merged 1 commit intocelery:masterfrom
auvipy:hapol

Conversation

@auvipy
Copy link
Member

@auvipy auvipy commented Aug 13, 2018

to fix #4896

@georgepsarakis
Copy link
Contributor

@auvipy have you perhaps checked which version of RabbitMQ is used on integration tests? Was this an error or just was discarded/ignored? Also, should we account for older versions as well?

@auvipy
Copy link
Member Author

auvipy commented Aug 13, 2018

definitely, I will. you could check the blog post on the reported issue

@auvipy
Copy link
Member Author

auvipy commented Aug 13, 2018

@joekohlsdorf

@joekohlsdorf
Copy link

In Travis no version of RabbitMQ is specified so it will use the latest image for integration testing.
The change in RabbitMQ was introduced with 3.0 and the last 2.x release was in 2012, I doubt anybody is using it in combination with the latest releases of Celery.

@auvipy
Copy link
Member Author

auvipy commented Aug 13, 2018

this will affect 3.x versions of rabbit

@auvipy auvipy merged commit 681a922 into celery:master Aug 13, 2018
@auvipy auvipy deleted the hapol branch August 20, 2018 07:47
krkmetal pushed a commit to krkmetal/celery that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CELERY_QUEUE_HA_POLICY has no effect on RabbitMQ 3 due to change of x-ha-policy to ha-mode

3 participants