Celery doesn't re-use DB connections with Django (fixes #4116) #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I would like to add that we use this fix successfully in production and hand no issues so far. |
|
Are there any plans for a patch fix (4.1.x) that will include this? |
|
@thedrow Is a 4.1.1 coming soon? Are there any PRs blocking it? |
Member
|
4.2 is coming one blocker remain. check the milestone |
snopoke
added a commit
to dimagi/commcare-cloud
that referenced
this pull request
Nov 21, 2018
* setting is not respected by celery < v4.2 * celery/celery#4292 * not compatible with 'gevent' gunicorn worker class * benoitc/gunicorn#996 (comment)
Member
|
this change is creating regression as per reports, should we revert this? |
Contributor
|
@thedrow I read the issues linking here, I think that they mostly concern finding a correct value for |
|
This PR actually broke celery's DB handling (see #5483). I would suggest a revert. |
2 tasks
Member
|
celery 4.x doesn't support Django-celery package |
Member
|
Please review this patch witch django-celery-beats and results |
auvipy
added a commit
that referenced
this pull request
May 15, 2019
11 tasks
jeyrce
pushed a commit
to jeyrce/celery
that referenced
this pull request
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4116
Celery doesn't re-use DB connections when the setting
CONN_MAX_AGEis set in Django. Instead connections are closed immediately. This leads to a high load on the database when there are a lot of Celery workers. It also affects query performance negatively.This PR uses the Django
close_if_unusable_or_obsolete()method to close a DB connection instead ofclose().close_if_unusable_or_obsolete()is available at least since Django 1.8 (see django/django@2830807) which is the minimum supported version for Celery 4.0.Let me know if you need anything else to merge this.