This repository was archived by the owner on Feb 17, 2025. It is now read-only.
feat: add field for minimum CLI version#61
Merged
mergify[bot] merged 1 commit intomainfrom Nov 7, 2024
Merged
Conversation
This is preparing for a future feature. A Cloud Assembly producer can't yet know what CLI version would be required to read it, but in the future once we tie the Cloud Assembly package version to the CLI package version, we will be able to do that. If we build the "check and report" feature in right now, at the time we start producing manifests with this field set, more CLI versions will be out that will be taking advantage of it, and reporting useful error messages.
mrgrain
approved these changes
Nov 7, 2024
github-merge-queue bot
pushed a commit
to cdklabs/cdk-assets
that referenced
this pull request
Jan 1, 2025
In cdklabs/cloud-assembly-schema#61, we bumped the schema version 39, but we didn't upgrade the dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is preparing for a future feature. A Cloud Assembly producer can't yet know what CLI version would be required to read it, but in the future once we tie the Cloud Assembly package version to the CLI package version, we will be able to do that.
If we build the "check and report" feature in right now, at the time we start producing manifests with this field set, more CLI versions will be out that will be taking advantage of it, and reporting useful error messages.