Add pTraceShow and pTraceShowWith#104
Conversation
That's a good question. I'll defer to @cdepillabout since I'm not usually in the habit of adding Also, could you please rebase on |
0a73cf0 to
55072e5
Compare
|
Warning pragmas and rebase done. Should be good to go. 👍 |
|
I think this looks good, but I do have one small concern. What if haskell/core-libraries-committee#36 gets accepted, but they slightly change the type signature or name of the proposed functions? Then we'll have do to a major version bump of (I don't think this is a really big concern or anything, but it might be easier to just hold off on merging this until the above issue gets decided. I'm fine with deferring to @georgefst to make the final call on this.) As for the |
Good point. I think it's best to wait for that proposal to be approved. I don't expect it'll take long, and I'm watching the thread. |
|
Solves #100
Adds pTraceWith and pTraceShowWith
I added some doc comments but was unsure if that something added just before merge. For instance the version number.
Let me know of any issues with this change. Thanks!