Skip to content

Add pTraceShow and pTraceShowWith#104

Merged
georgefst merged 2 commits intocdepillabout:masterfrom
LeviButcher:pTraceWith
Jun 7, 2022
Merged

Add pTraceShow and pTraceShowWith#104
georgefst merged 2 commits intocdepillabout:masterfrom
LeviButcher:pTraceWith

Conversation

@LeviButcher
Copy link
Copy Markdown
Contributor

Solves #100
Adds pTraceWith and pTraceShowWith

I added some doc comments but was unsure if that something added just before merge. For instance the version number.

Let me know of any issues with this change. Thanks!

@georgefst
Copy link
Copy Markdown
Collaborator

I added some doc comments but was unsure if that something added just before merge.

That's a good question. I'll defer to @cdepillabout since I'm not usually in the habit of adding @since annotations (They are definitely good to have! It just seems like something crying out for some sort of automated tooling, which AFAIK doesn't exist. And I'm lazy.).

Also, could you please rebase on master, and add pragmas as in #103? Thanks!

@LeviButcher
Copy link
Copy Markdown
Contributor Author

Warning pragmas and rebase done. Should be good to go. 👍

@cdepillabout
Copy link
Copy Markdown
Owner

I think this looks good, but I do have one small concern.

What if haskell/core-libraries-committee#36 gets accepted, but they slightly change the type signature or name of the proposed functions? Then we'll have do to a major version bump of pretty-simple to match the changes.

(I don't think this is a really big concern or anything, but it might be easier to just hold off on merging this until the above issue gets decided. I'm fine with deferring to @georgefst to make the final call on this.)


As for the @since annotations, I completely agree with @georgefst. They are great to have, but annoying to maintain without some sort of automated tooling. I generally haven't been adding them.

@georgefst
Copy link
Copy Markdown
Collaborator

What if haskell/core-libraries-committee#36 gets accepted, but they slightly change the type signature or name of the proposed functions?

Good point. I think it's best to wait for that proposal to be approved. I don't expect it'll take long, and I'm watching the thread.

@georgefst
Copy link
Copy Markdown
Collaborator

Good point. I think it's best to wait for that proposal to be approved. I don't expect it'll take long, and I'm watching the thread.

Approved: haskell/core-libraries-committee#36 (comment)!

@georgefst georgefst merged commit c14b7bc into cdepillabout:master Jun 7, 2022
@cdepillabout cdepillabout mentioned this pull request Jun 8, 2022
@LeviButcher LeviButcher deleted the pTraceWith branch January 26, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants