Skip to content

Added warnings for deprecation#103

Merged
georgefst merged 1 commit intocdepillabout:masterfrom
chaughawout:patch-1
Feb 26, 2022
Merged

Added warnings for deprecation#103
georgefst merged 1 commit intocdepillabout:masterfrom
chaughawout:patch-1

Conversation

@chaughawout
Copy link
Copy Markdown
Contributor

#101
Straightforward. Implemented like protolude has implemented, but could use the DEPRECATED pragma instead. Let's discuss.

cdepillabout#101 Straightforward. Implemented like protolude has implemented, but could use the DEPRECATED pragma instead. Let's discuss in the PR.
@chaughawout
Copy link
Copy Markdown
Contributor Author

I don't do much haskell development, so if there's anything style wise or additional things to consider here, please let me know. It seems straightforward enough.

@georgefst
Copy link
Copy Markdown
Collaborator

Looks good, thanks!

I had just assumed that protolude was using the DEPRECATED pragma since it shows up as a warning under -Wdeprecations. This way is better.

@georgefst georgefst merged commit c07a1c4 into cdepillabout:master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants