fix(Modal): add closeButtonLabel prop, add default value#9998
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 0edbd61 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617ca5277e737b0007015177 😎 Browse the preview: https://deploy-preview-9998--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 0edbd61 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617ca527aa7a1a0008064290 😎 Browse the preview: https://deploy-preview-9998--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 0edbd61 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617ca527c9aa06000709242f 😎 Browse the preview: https://deploy-preview-9998--carbon-elements.netlify.app |
…gn-system#9998) Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
adds ability to set a label on the close button (for translation purposes, and sets a default value to clear accessibility checker errors
Testing / Reviewing
either pass a
closeButtonLabelprop, or check to see that the close button has the appropriate label in the dom/accessibility tree 🏄🏾