Skip to content

style(DataTable): updated tokens#9942

Merged
sstrubberg merged 5 commits into
carbon-design-system:mainfrom
sstrubberg:style/datatable-tokens
Oct 26, 2021
Merged

style(DataTable): updated tokens#9942
sstrubberg merged 5 commits into
carbon-design-system:mainfrom
sstrubberg:style/datatable-tokens

Conversation

@sstrubberg

@sstrubberg sstrubberg commented Oct 25, 2021

Copy link
Copy Markdown
Member

REF #9888

Updated tokens to v11 based on the following specs.

Questions

I didn't see a DataTable story in carbon-react so I'm not exactly sure how to test this, other than to say that I was able to load storybook locally after I updated the lone ui-05 token.

@sstrubberg sstrubberg requested a review from a team as a code owner October 25, 2021 21:49
@netlify

netlify Bot commented Oct 25, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 264d010

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61784e23946504000800ec97

😎 Browse the preview: https://deploy-preview-9942--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 25, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 264d010

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61784e23d0d3c50007585d58

😎 Browse the preview: https://deploy-preview-9942--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 25, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 264d010

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61784e2315682900083ac88f

😎 Browse the preview: https://deploy-preview-9942--carbon-components-react.netlify.app

@sstrubberg sstrubberg merged commit 16785a3 into carbon-design-system:main Oct 26, 2021
kennylam pushed a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
…gn-system#9942)

### Related Ticket(s)

[breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936
Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923

### Description

Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours.

### Changelog

**Changed**

- added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants