Skip to content

feat(TimePickerSelect): updated props for v11#9914

Merged
sstrubberg merged 19 commits into
carbon-design-system:mainfrom
sstrubberg:feat/timepickerselect
Oct 28, 2021
Merged

feat(TimePickerSelect): updated props for v11#9914
sstrubberg merged 19 commits into
carbon-design-system:mainfrom
sstrubberg:feat/timepickerselect

Conversation

@sstrubberg

@sstrubberg sstrubberg commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

REF #9535 #9624

Refactoring TimePickerSelect with prop changes in preparation for migration to a functional component.

Storybook

  • Removed iconDescription from "Select" in the TimePicker story.
  • Added an aria-label knob to "Select" in the TimePicker story.

TimePickerSelect

  • Added a deprecation warning to iconDescription.
  • Remove the unused inline prop.
  • Put the props in alphabetical order.
  • Renamed ...other -> ...rest
  • Added an ariaLabel prop.
  • Added proper aria attributes to the Chevron.

Testing

  • Make sure TimePicker tests are passing.
  • Ensure TimePicker does it's thing in Storybook, especially as it pertains to TimePickerSelect.

@sstrubberg sstrubberg requested a review from a team as a code owner October 20, 2021 21:31
@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 7edaf41

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6179f6f5190cef0007f8272d

😎 Browse the preview: https://deploy-preview-9914--carbon-react-next.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 7edaf41

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6179f6f52e83dd0007335ad2

😎 Browse the preview: https://deploy-preview-9914--carbon-elements.netlify.app

@netlify

netlify Bot commented Oct 20, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7edaf41

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6179f6f500e7b10007063332

😎 Browse the preview: https://deploy-preview-9914--carbon-components-react.netlify.app

@sstrubberg sstrubberg requested a review from a team as a code owner October 21, 2021 14:08
abbeyhrt
abbeyhrt reviewed Oct 25, 2021
View reviewed changes
Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js Outdated
abbeyhrt
abbeyhrt reviewed Oct 25, 2021
View reviewed changes
Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js
@sstrubberg @abbeyhrt
Update packages/react/src/components/TimePickerSelect/TimePickerSelec…
fc92c7c 
…t.js

Co-authored-by: Abbey Hart <abbeyhrt@gmail.com>
@sstrubberg sstrubberg requested a review from abbeyhrt October 25, 2021 19:24
tay1orjones
tay1orjones reviewed Oct 25, 2021
View reviewed changes

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

Do we need to change the labelClasses block w/ visually-hidden to always be true since the hideLabel default has been removed? https://github.com/carbon-design-system/carbon/pull/9914/files#diff-a67cbb553a741d3befb1f3b64288b2c0acf8e9f033976bf1f2bd5a7553138ad8R97-R100

Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js Outdated
@sstrubberg @tay1orjones
Update packages/react/src/components/TimePickerSelect/TimePickerSelec…
57ecc77 
…t.js

Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
@sstrubberg

sstrubberg commented Oct 25, 2021

Copy link
Copy Markdown
Member Author

Overall looks good!

Do we need to change the labelClasses block w/ visually-hidden to always be true since the hideLabel default has been removed? https://github.com/carbon-design-system/carbon/pull/9914/files#diff-a67cbb553a741d3befb1f3b64288b2c0acf8e9f033976bf1f2bd5a7553138ad8R97-R100

I'm going to do that with this PR.

tay1orjones
tay1orjones reviewed Oct 25, 2021
View reviewed changes
Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js
joshblack
joshblack suggested changes Oct 26, 2021
View reviewed changes
Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js Outdated
Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js Outdated
Comment thread packages/react/src/components/TimePickerSelect/TimePickerSelect.js Outdated
@sstrubberg sstrubberg requested a review from joshblack October 26, 2021 18:53
@sstrubberg sstrubberg mentioned this pull request Oct 26, 2021
Merged
abbeyhrt
abbeyhrt approved these changes Oct 26, 2021
View reviewed changes

@abbeyhrt abbeyhrt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@sstrubberg sstrubberg enabled auto-merge (squash) October 26, 2021 21:47
@sstrubberg sstrubberg merged commit 580df55 into carbon-design-system:main Oct 28, 2021
@sstrubberg sstrubberg deleted the feat/timepickerselect branch October 28, 2021 02:37
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
fix(masthead): update logo url protocol (carbon-design-system#9914)
8a0e408 
### Related Ticket(s)

carbon-design-system#9567 

### Description

This updates the React masthead logo URL to use `https`.

### Changelog

**Changed**

- React masthead logo URL changed to use `https`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

+2 more reviewers

@joshblack joshblack joshblack approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sstrubberg @tay1orjones @joshblack @abbeyhrt