feat(MultiSelect): new hideLabel prop#9840
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 39cd3a0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6167f210c510f500071e2c91 😎 Browse the preview: https://deploy-preview-9840--carbon-react-next.netlify.app |
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 39cd3a0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6167f210f3daa600080f6b98 😎 Browse the preview: https://deploy-preview-9840--carbon-components-react.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 39cd3a0 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6167f2104319350009018f3c 😎 Browse the preview: https://deploy-preview-9840--carbon-elements.netlify.app |
|
recheck |
sstrubberg
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Couple of things that might help resolve your CI errors.
-
Run
yarn test packages/react/__tests__/PublicAPI-test.js -ufrom the root of the project. That might resolve the following error. If you made any manual changes to this file, I would undo them first, then run the command.
-
Run
yarn format:difffrom the root of the project to clean up any formatting errors.
5b808ee to
8330518
Compare
- Add `hideLabel` prop to the filterable MultiSelect to make it consistant with the default MultiSelect. - Fix up `PublicAPI-test.js.snap` file using command `yarn test packages/react/__tests__/PublicAPI-test.js -u`. First the file was restored to commit 3e0231d, then the `yarn test` was used to make changes to `PublicAPI-test.js.snap`. - Fix format issue (spaces) in MultiSelect.js
8330518 to
fea178c
Compare
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
|
Since last request for review, I did
|
Add a
hideLabelprop similar to theDropdowncomponent (ref #7594 ref #7571). ThetitleTextis the currently the only way to set the<label>but there is no way to visually hide thetitleTextwhen it is set.Changelog
New
hideLabelprop to allow for the hiding of the title textTesting / Reviewing
I am not sure how to build and test this pull request. I am hoping opening this pull request will deploy my pull request in a demo site where I can try the file changes.