feat(Dropdown): add hideTitleText prop#7594
Conversation
|
Deploy preview for carbon-elements ready! Built with commit b7c027d |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit b7c027d https://deploy-preview-7594--carbon-components-react.netlify.app |
There was a problem hiding this comment.
would you mind renaming the prop to hideLabel to match the other Carbon components? also it looks like you will need to update snapshots in order to pass CI
edit: yeah it looks like only the listbox components use "title" instead of "label" but this may need to be updated in the future to match the existing components like TextInput, Select, etc.
…hideLabel-dropdown
…hideLabel-dropdown merge with master please
tw15egan
left a comment
There was a problem hiding this comment.
Not seeing any a11y errors with the hideLabel prop enabled. Thanks for contributing! LGTM 👍 ✅
Closes #
Addresses this issue #7571
Changelog
New
hideTitleTextprop for the Dropdown. ThetitleTextwill still exist programatically but hiding it visually lends itself to smoother design (especially with inline Dropdowns). This sort of prop also exists in the Select component.Testing / Reviewing
hideTitleTextprophideTitleTextbeing true. There should not be an error for "The WAI-ARIA property must reference a non-empty unique id of an existing element that is visible" which normally occurs when thetitleTextis missing entirely. However, because we have hidden it visually but not programatically, the error shouldn't appear.