Skip to content

fix(progress-indicator): fix active state#9740

Merged
andreancardona merged 17 commits into
carbon-design-system:mainfrom
andreancardona:9733-progress-indicator-active-state
Oct 18, 2021
Merged

fix(progress-indicator): fix active state#9740
andreancardona merged 17 commits into
carbon-design-system:mainfrom
andreancardona:9733-progress-indicator-active-state

Conversation

@andreancardona

@andreancardona andreancardona commented Sep 24, 2021

Copy link
Copy Markdown
Contributor

Closes #9733

This PR adds the :active state to interactive steps that do not have a tooltip. Checkout original issue for full details.

  • Make sure interactive step that does not have tooltip has :active

@andreancardona andreancardona requested a review from a team as a code owner September 24, 2021 17:47
@netlify

netlify Bot commented Sep 24, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ca8800e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/616cbe36cbf5400008170e96

😎 Browse the preview: https://deploy-preview-9740--carbon-react-next.netlify.app

@andreancardona andreancardona changed the title 9733 progress indicator active state fix(progress-indicator): fix active state Sep 24, 2021
@netlify

netlify Bot commented Sep 24, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: a74eb8a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614e0f1fb2803e00080bc5e5

😎 Browse the preview: https://deploy-preview-9740--carbon-elements.netlify.app

@netlify

netlify Bot commented Sep 24, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: a74eb8a

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614e0f1f357b1e0007ec43ec

😎 Browse the preview: https://deploy-preview-9740--carbon-components-react.netlify.app

@netlify

netlify Bot commented Sep 24, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ca8800e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/616cbe36f7474f00070d5605

😎 Browse the preview: https://deploy-preview-9740--carbon-components-react.netlify.app

@netlify

netlify Bot commented Sep 24, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ca8800e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/616cbe3675050e0008f591ee

😎 Browse the preview: https://deploy-preview-9740--carbon-elements.netlify.app

@janhassel

janhassel commented Sep 27, 2021

Copy link
Copy Markdown
Member

Testing out the storybook preview this seems to also add the :active state on non-interactive steps ("Really long label" in the story) again. Ref #9609

Would .bx--progress-step-button:not(.bx--progress-step-button--unclickable) .bx--progress-label be an appropriate selector for this? If :not() is discouraged, I think there would need to be a class .bx--progress-step-button--clickable to identify interactive steps of any kind.

joshblack
joshblack previously requested changes Sep 28, 2021
View reviewed changes

@joshblack joshblack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, wrong button click 🤦 Quick +1 to Jan's comments above

@tay1orjones tay1orjones mentioned this pull request Oct 4, 2021
Closed
57 tasks
@andreancardona

andreancardona commented Oct 8, 2021

Copy link
Copy Markdown
Contributor Author

@janhassel Hey Jan! Good catch, just pushed up your fix. :)

jnm2377
jnm2377 suggested changes Oct 11, 2021
View reviewed changes
Comment thread packages/components/src/components/progress-indicator/_progress-indicator.scss
@github-actions

github-actions Bot commented Oct 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

DCO Assistant Lite bot All contributors have signed the DCO.

@andreancardona

andreancardona commented Oct 12, 2021

Copy link
Copy Markdown
Contributor Author

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:

I have read the DCO document and I hereby sign the DCO.

1 out of 2 committers have signed the DCO.✅ @andreancardona❌ @Andrea CardonaAndrea Cardona seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.You can retrigger this bot by commenting recheck in this Pull Request

recheck

jnm2377
jnm2377 suggested changes Oct 13, 2021
View reviewed changes
Comment thread packages/styles/scss/components/progress-indicator/_progress-indicator.scss Outdated
@andreancardona andreancardona enabled auto-merge (squash) October 13, 2021 17:29
@theiliad

theiliad commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

@andreancardona
image

@andreancardona andreancardona merged commit 021df4c into carbon-design-system:main Oct 18, 2021
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
feat(tile): add custom event to selected-tile (carbon-design-system…
1c9c7d8 
…#9898)

### Related Ticket(s)

carbon-design-system#9740 

### Description

Adds custom event after `selectable-tile` is selected

### Changelog

**New**

- `bx-selectable-tile-changed` custom event added to `selectable-tile`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack Awaiting requested review from joshblack

3 more reviewers

@aledavila aledavila aledavila approved these changes

@theiliad theiliad theiliad approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: ProgressIndicator – interactive progress indicator steps do not receive :active state

6 participants

@andreancardona @janhassel @theiliad @joshblack @aledavila @jnm2377