fix(overflow-menu): firefox bug with focus outline#476
Merged
marijohannessen merged 1 commit intoJan 4, 2018
Merged
Conversation
Contributor
|
Hmm, seems like we lose the outline when the menu is open in Chrome now. Could we target only Firefox with this fix? |
Contributor
|
Disregard, seems like we always lose the outline in Chrome once the menu is opened. 👍 ✅ |
asudoh
pushed a commit
to asudoh/carbon-components
that referenced
this pull request
Jan 5, 2018
asudoh
pushed a commit
to asudoh/carbon-components
that referenced
this pull request
Jan 5, 2018
designertyler
pushed a commit
to designertyler/carbon
that referenced
this pull request
Oct 14, 2019
* fix: update charts ci fix * fix: one more upgrade * fix: 15
paul-palade
added a commit
to paul-palade/carbon
that referenced
this pull request
May 25, 2026
Submitting 2 new UI icons from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issues carbon-design-system#474, 475 and carbon-design-system#476 in brand/ui-icons. ### Changelog **New** `Systems` - [x] 32/coupling-facility.svg - [x] 32/zos--partition.svg **Updated** `Systems` - 32/coupling-facility-encryption.svg Updated aliases in icons.yml
paul-palade
added a commit
to paul-palade/carbon
that referenced
this pull request
May 25, 2026
Submitting 2 new UI icons from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issues carbon-design-system#474, 475 and carbon-design-system#476 in brand/ui-icons. ### Changelog **New** `Systems` - [x] 32/coupling-facility.svg - [x] 32/zos--partition.svg **Updated** `Systems` - 32/coupling-facility-encryption.svg Updated aliases in icons.yml
iamnexxed
pushed a commit
to iamnexxed/carbon
that referenced
this pull request
May 29, 2026
* feat(icons): new Icons June 2026 Submitting 2 new UI icons from June 2026 and updated categories. Updated master file. All additions and updates approved by BXD. Addressing issues carbon-design-system#474, 475 and carbon-design-system#476 in brand/ui-icons. ### Changelog **New** `Systems` - [x] 32/coupling-facility.svg - [x] 32/zos--partition.svg **Updated** `Systems` - 32/coupling-facility-encryption.svg Updated aliases in icons.yml * Fixed rendering issue (Systems): 32/coupling-facility.svg Updating 1 UI icon from June 2026 and updated categories. All additions and updates approved by BXD. ### Changelog **Updated** `Systems` - [x] 32/coupling-facility.svg Fixed rendering issue with the SVG vector displaying broken line. * Update packages/icons/icons.yml Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> * chore: update snapshots --------- Co-authored-by: Mahmoud <132728978+maradwan26@users.noreply.github.com> Co-authored-by: Mahmoud <maradwan26@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #475
Firefox includes absolutely positioned children in the focus style of a containing element, as a result OverflowMenu would have a larger focus outline in Firefox than it would in other browsers.
This PR adjusts the focus styles to be based on
box-shadowinstead ofoutlineto resolve this behavior forcarbon-components-reactChangelog
New
Changed
box-shadowfor focus statesRemoved