fix(radio-button): Squished on overflow text#323
Merged
tw15egan merged 1 commit intoSep 21, 2017
Merged
Conversation
Contributor
|
👍 ✅ Looks good to me! |
Contributor
|
👍 ✅ Thanks for fixing that! |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 2, 2019
…#323) componentWillReceiveProps was doing a check on object vs object. Even if the objects had the same props, it would always return false because JavaScript. Doing a very simple toString-like check is a better check updatePosition changed too much state and fired onChange too much as well. It would fire on every mouse move, even if the value didn't actually change Fixes carbon-design-system#329
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
May 8, 2019
…n-system#323) * fix $expressive-heading-04 line height at mobile Line height should be the same at every breakpoint at Step 6 for $expressive-heading-04; it only changes when the type size changes at max breakpoint to step 7. * fix(type): update line-height in scss * chore(test): update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #322
Adds flex shrink to prevent distorting radio button. Check it out here by removing the commented out style.